[GitHub] [arrow] westonpace commented on pull request #34537: GH-14939: [C++] Support Table lookups in FieldRef and FieldPath

["westonpace (via GitHub)" <gi...@apache.org>]

westonpace commented on PR #34537:
URL: https://github.com/apache/arrow/pull/34537#issuecomment-1483052917

   > @zeroshade @westonpace Looking at this a little deeper... do you know if FieldPath::Get is meant to be zero-copy? I'm not entirely sure if my suggestion to use ChunkedArray::Flatten here was appropriate since I believe it collapses top-level nulls. The Get implementations for Array and RecordBatch both use their underlying ArrayData exclusively without modifying/copying anything (regardless of nesting level).
   
   Yes, `Get` is meant to be zero-copy.  This came up in discussion a little while back.  See https://github.com/apache/arrow/issues/14946  I believe the consensus was that `FieldRef::Get` has been around long enough that changing the definition now (to mean a flattened get) would be a breaking change and a better approach would be to introduce a `GetFlattened` alongside `Get`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org