You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/27 03:20:06 UTC

[GitHub] [hudi] huberylee opened a new pull request, #5441: Claim RFC 52 for Introduce Secondary Index to Improve HUDI Query Performance

huberylee opened a new pull request, #5441:
URL: https://github.com/apache/hudi/pull/5441

   …ormance
   
   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5441: [HUDI-3907]Claim RFC 52 for Introduce Secondary Index to Improve HUDI Query Performance

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5441:
URL: https://github.com/apache/hudi/pull/5441#issuecomment-1110508131

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8bc3917fb279a102c97b82f51c8053ee46ed8069",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8340",
       "triggerID" : "8bc3917fb279a102c97b82f51c8053ee46ed8069",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8bc3917fb279a102c97b82f51c8053ee46ed8069 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8340) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] XuQianJin-Stars merged pull request #5441: [HUDI-3907]Claim RFC 52 for Introduce Secondary Index to Improve HUDI Query Performance

Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars merged PR #5441:
URL: https://github.com/apache/hudi/pull/5441


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] huberylee commented on pull request #5441: [HUDI-3907]Claim RFC 52 for Introduce Secondary Index to Improve HUDI Query Performance

Posted by GitBox <gi...@apache.org>.
huberylee commented on PR #5441:
URL: https://github.com/apache/hudi/pull/5441#issuecomment-1110601695

   > +1 but can we rename the RFC title to be more specific about the lucene index? There is also a separate record level/HFile backed index going on.
   > 
   > So may be "Introduce Lucene based secondary indexing" ?
   
   We want to introduce a common architecture for secondary index, and lucene based secondary index is one specific implementation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] huberylee commented on pull request #5441: [HUDI-3907]Claim RFC 52 for Introduce Secondary Index to Improve HUDI Query Performance

Posted by GitBox <gi...@apache.org>.
huberylee commented on PR #5441:
URL: https://github.com/apache/hudi/pull/5441#issuecomment-1110602355

   > Otherwise lgtm to land. Look forward to this contribution. Also please take note of the recent work around async index building #4640 , would be cool to have this integrated so that indexes can be built and rebuilt asynchronously!
   
   OK.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5441: Claim RFC 52 for Introduce Secondary Index to Improve HUDI Query Performance

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5441:
URL: https://github.com/apache/hudi/pull/5441#issuecomment-1110492016

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8bc3917fb279a102c97b82f51c8053ee46ed8069",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8bc3917fb279a102c97b82f51c8053ee46ed8069",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8bc3917fb279a102c97b82f51c8053ee46ed8069 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5441: [HUDI-3907]Claim RFC 52 for Introduce Secondary Index to Improve HUDI Query Performance

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5441:
URL: https://github.com/apache/hudi/pull/5441#issuecomment-1110510821

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8bc3917fb279a102c97b82f51c8053ee46ed8069",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8340",
       "triggerID" : "8bc3917fb279a102c97b82f51c8053ee46ed8069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1478ed5a3aef86a00bb4161351efb70081d79ae7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1478ed5a3aef86a00bb4161351efb70081d79ae7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8bc3917fb279a102c97b82f51c8053ee46ed8069 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8340) 
   * 1478ed5a3aef86a00bb4161351efb70081d79ae7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5441: [HUDI-3907]Claim RFC 52 for Introduce Secondary Index to Improve HUDI Query Performance

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5441:
URL: https://github.com/apache/hudi/pull/5441#issuecomment-1110509438

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8bc3917fb279a102c97b82f51c8053ee46ed8069",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8340",
       "triggerID" : "8bc3917fb279a102c97b82f51c8053ee46ed8069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1478ed5a3aef86a00bb4161351efb70081d79ae7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1478ed5a3aef86a00bb4161351efb70081d79ae7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8bc3917fb279a102c97b82f51c8053ee46ed8069 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8340) 
   * 1478ed5a3aef86a00bb4161351efb70081d79ae7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5441: [HUDI-3907]Claim RFC 52 for Introduce Secondary Index to Improve HUDI Query Performance

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5441:
URL: https://github.com/apache/hudi/pull/5441#issuecomment-1110540762

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8bc3917fb279a102c97b82f51c8053ee46ed8069",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8340",
       "triggerID" : "8bc3917fb279a102c97b82f51c8053ee46ed8069",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1478ed5a3aef86a00bb4161351efb70081d79ae7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8342",
       "triggerID" : "1478ed5a3aef86a00bb4161351efb70081d79ae7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8bc3917fb279a102c97b82f51c8053ee46ed8069 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8340) 
   * 1478ed5a3aef86a00bb4161351efb70081d79ae7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8342) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar commented on pull request #5441: [HUDI-3907]Claim RFC 52 for Introduce Secondary Index to Improve HUDI Query Performance

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on PR #5441:
URL: https://github.com/apache/hudi/pull/5441#issuecomment-1110567040

   Otherwise lgtm to land. Look forward to this contribution. Also please take note of the recent work around async index building #4640 , would be cool to have this integrated so that indexes can be built and rebuilt asynchronously!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org