[jira] [Commented] (AIRFLOW-4331) dag_details generates bad filter in taskinstance link

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16819942#comment-16819942 ] 

ASF GitHub Bot commented on AIRFLOW-4331:
-----------------------------------------

ashb commented on pull request #5122: [AIRFLOW-4331] Fix incorrect link on Dag Details page
URL: https://github.com/apache/airflow/pull/5122
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] https://issues.apache.org/jira/browse/AIRFLOW-4331
     
   ### Description
   
   - [x] This part of the UI isn't often used, but it was in-operable. (To get to it click on the Edit icon (first column) from dags screen, then select List. It would blow up.
   
     That column formatter is used in a few places (Dag, DagRun, TI) so it needs to cope with differing input types.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: tested manually. 
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] None
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> dag_details generates bad filter in taskinstance link
> -----------------------------------------------------
>
>                 Key: AIRFLOW-4331
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4331
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ui
>    Affects Versions: 1.10.3
>            Reporter: t oo
>            Assignee: Ash Berlin-Taylor
>            Priority: Major
>         Attachments: Untitled2.png, image-2019-04-16-12-48-38-314.png
>
>
> dag_details generates bad filter (&flt2_state_equals=None) in taskinstance link, it should be filter of: &flt3_state_empty=1
>  
> see screenshots



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)