You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2019/09/29 09:43:43 UTC
svn commit: r1867717 -
/ofbiz/ofbiz-plugins/trunk/ecommerce/template/catalog/ProductReview.ftl
Author: jleroux
Date: Sun Sep 29 09:43:42 2019
New Revision: 1867717
URL: http://svn.apache.org/viewvc?rev=1867717&view=rev
Log:
Fixed: Freemarker error on reviewProduct page on storefront
(OFBIZ-11108)
Steps to regenerate:
1)Navigate to https://demo-trunk.ofbiz.apache.org/ecommerce/control/main
2) User should not be logged in
3) Click on any product
4) Click on Be The First To Review This Product! link
5) FTL error for the null check is occurring
Thanks: Minal Phalak for the patch and Suraj for review
Modified:
ofbiz/ofbiz-plugins/trunk/ecommerce/template/catalog/ProductReview.ftl
Modified: ofbiz/ofbiz-plugins/trunk/ecommerce/template/catalog/ProductReview.ftl
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/ecommerce/template/catalog/ProductReview.ftl?rev=1867717&r1=1867716&r2=1867717&view=diff
==============================================================================
--- ofbiz/ofbiz-plugins/trunk/ecommerce/template/catalog/ProductReview.ftl (original)
+++ ofbiz/ofbiz-plugins/trunk/ecommerce/template/catalog/ProductReview.ftl Sun Sep 29 09:43:42 2019
@@ -20,10 +20,10 @@ under the License.
<#if requestParameters.product_id??>
<form id="reviewProduct" method="post" action="<@o...@ofbizUrl>">
<fieldset class="inline">
- <input type="hidden" name="productStoreId" value="${productStore.productStoreId}" />
+ <input type="hidden" name="productStoreId" value="${(productStore.productStoreId)!}" />
<input type="hidden" name="productId" value="${requestParameters.product_id}" />
<input type="hidden" name="product_id" value="${requestParameters.product_id}" />
- <input type="hidden" name="category_id" value="${requestParameters.category_id}" />
+ <input type="hidden" name="category_id" value="${(requestParameters.category_id)!}" />
<div>
<label for="one">${uiLabelMap.EcommerceRating}:</label>
<div class="form-check form-check-inline">