You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/28 09:10:37 UTC
[GitHub] [flink] MartijnVisser opened a new pull request, #20090: [FLINK-28269][Kubernetes] Install cri-dockerd when running Kubernetes tests
MartijnVisser opened a new pull request, #20090:
URL: https://github.com/apache/flink/pull/20090
## What is the purpose of the change
* All Kubernetes Bash tests are currently failing because Kubernetes 1.24+ has dropped support for Dockershim. If we want to continue using the combination of the none Driver, Kubernetes 1.24+ and the Docker container runtime, we'll need to install cri-dockerd. This is listed in the requirements at https://minikube.sigs.k8s.io/docs/drivers/none/#requirements
## Brief change log
* Install cri-dockerd during the setup of Kubernetes
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #20090: [FLINK-28269][Kubernetes] Install cri-dockerd and crictl so we can continue using driver `none` when running Kubernetes tests
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20090:
URL: https://github.com/apache/flink/pull/20090#issuecomment-1170386283
It's fixed for the currently supported branches. I've created https://issues.apache.org/jira/browse/FLINK-28304 as a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #20090: [FLINK-28269][Kubernetes] Install cri-dockerd and crictl so we can continue using driver `none` when running Kubernetes tests
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on PR #20090:
URL: https://github.com/apache/flink/pull/20090#issuecomment-1169735887
Hmm. If we want a quick fix, then maybe `--kubernetes-version` could be used to pin the K8s version lower than 1.24.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #20090: [FLINK-28269][Kubernetes] Install cri-dockerd when running Kubernetes tests
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20090:
URL: https://github.com/apache/flink/pull/20090#issuecomment-1169727252
When switching from driver `none` to setting nothing (and therefore going to `docker`), the tests are timing out. Let's first remove this blocker by installing the additional dependencies to keep continuing with driver `none` and open up a follow ticket for switching to another setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lsyldliu commented on pull request #20090: [FLINK-28269][Kubernetes] Install cri-dockerd and crictl so we can continue using driver `none` when running Kubernetes tests
Posted by GitBox <gi...@apache.org>.
lsyldliu commented on PR #20090:
URL: https://github.com/apache/flink/pull/20090#issuecomment-1170166916
@MartijnVisser merge it now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20090: [FLINK-28269][Kubernetes] Install cri-dockerd when running Kubernetes tests
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20090:
URL: https://github.com/apache/flink/pull/20090#issuecomment-1168457523
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a9e392ec07bb3b9f79ccf5ee0395f690e9faaf17",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a9e392ec07bb3b9f79ccf5ee0395f690e9faaf17",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a9e392ec07bb3b9f79ccf5ee0395f690e9faaf17 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #20090: [FLINK-28269][Kubernetes] Install cri-dockerd when running Kubernetes tests
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on PR #20090:
URL: https://github.com/apache/flink/pull/20090#issuecomment-1169620436
Sorry for missing the comments. I remember the `none` driver is introduced before minikube has the `docker` driver. If we do not use the `none` driver, then we have to use vm driver `hyperkit`, `vmware`. It is a little heavy and we need to do some changes for building the images since the file server is not starting on "localhost". Another thing is we need to import the images into vm so that it could be used in the minikube.
All in all, I think now we could use the `docker` driver and fix the potential issues if we still have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #20090: [FLINK-28269][Kubernetes] Install cri-dockerd and crictl so we can continue using driver `none` when running Kubernetes tests
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20090:
URL: https://github.com/apache/flink/pull/20090#issuecomment-1169958587
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #20090: [FLINK-28269][Kubernetes] Install cri-dockerd when running Kubernetes tests
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on PR #20090:
URL: https://github.com/apache/flink/pull/20090#issuecomment-1169601350
Maybe we could try to remove the driver `none` and let the minikube select the driver automatically. We have removed the `none` driver in the flink-kubernetes-operator project.
```
start_minikube
shell: /usr/bin/bash -e {0}
env:
JAVA_HOME: /opt/hostedtoolcache/Java_Adopt_jdk/11.0.11-9/x6[4](https://github.com/apache/flink-kubernetes-operator/runs/7103609311?check_suite_focus=true#step:5:4)
* Profile "minikube" not found. Run "minikube profile list" to view all profiles.
To start a cluster, run: "minikube start"
Starting minikube ...
* minikube v1.26.0 on Ubuntu 20.04
* Automatically selected the docker driver. Other choices: podman, ssh, none
* Using Docker driver with root privileges
* Starting control plane node minikube in cluster minikube
* Pulling base image ...
* Downloading Kubernetes v1.24.1 preload ...
* Creating docker container (CPUs=2, Memory=2200MB) ...
* Preparing Kubernetes v1.24.1 on Docker 20.10.17 ...
- kubelet.image-gc-high-threshold=99
- kubelet.image-gc-low-threshold=98
- kubelet.minimum-container-ttl-duration=120m
- kubelet.eviction-hard=memory.available<[5](https://github.com/apache/flink-kubernetes-operator/runs/7103609311?check_suite_focus=true#step:5:5)Mi,nodefs.available<1Mi,imagefs.available<1Mi
- kubelet.eviction-soft=memory.available<5Mi,nodefs.available<2Mi,imagefs.available<2Mi
- kubelet.eviction-soft-grace-period=memory.available=2h,nodefs.available=2h,imagefs.available=2h
- Generating certificates and keys ...
- Booting up control plane ...
- Configuring RBAC rules ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #20090: [FLINK-28269][Kubernetes] Install cri-dockerd when running Kubernetes tests
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20090:
URL: https://github.com/apache/flink/pull/20090#issuecomment-1169606056
> Maybe we could try to remove the driver `none` and let the minikube select the driver automatically. We have removed the `none` driver in the flink-kubernetes-operator project.
That was the reason why I asked Robert and yourself in https://issues.apache.org/jira/browse/FLINK-28269 if we had made a deliberate decision to go for driver `none`.
Should it be sufficient to remove `--vm-driver=none` from https://github.com/apache/flink/blob/master/flink-end-to-end-tests/test-scripts/common_kubernetes.sh#L81 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #20090: [FLINK-28269][Kubernetes] Install cri-dockerd and crictl so we can continue using driver `none` when running Kubernetes tests
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20090:
URL: https://github.com/apache/flink/pull/20090#issuecomment-1169747835
> Hmm. If we want a quick fix, then maybe `--kubernetes-version` could be used to pin the K8s version lower than 1.24.
I'm not sure about that, because we've always tested against the latest version. If we now pin to specific version, we might face issues with newer versions which we won't test against.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #20090: [FLINK-28269][Kubernetes] Install cri-dockerd when running Kubernetes tests
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20090:
URL: https://github.com/apache/flink/pull/20090#issuecomment-1169647045
Allright. I'm currently running two different test runs on my personal CI: [one](https://dev.azure.com/martijn0323/Flink/_build/results?buildId=2775&view=results) where we add `cri-dockerd` and `crictl` while continuing to use driver `none` and [another](https://dev.azure.com/martijn0323/Flink/_build/results?buildId=2776) one where I've removed driver `none`.
If the last one works, I'll update this PR to take care of that. If that doesn't work, we can have a look at the first one.
Sidenote: it would be great if we can find someone who wants to migrate the Bash Kubernetes tests to Java. I've created a bunch of tickets for that yesterday (see for example https://issues.apache.org/jira/browse/FLINK-28277)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #20090: [FLINK-28269][Kubernetes] Install cri-dockerd and crictl so we can continue using driver `none` when running Kubernetes tests
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20090:
URL: https://github.com/apache/flink/pull/20090#issuecomment-1169748838
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #20090: [FLINK-28269][Kubernetes] Install cri-dockerd and crictl so we can continue using driver `none` when running Kubernetes tests
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on PR #20090:
URL: https://github.com/apache/flink/pull/20090#issuecomment-1169780878
> I'm not sure about that, because we've always tested against the latest version. If we now pin to specific version, we might face issues with newer versions which we won't test against.
Make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser merged pull request #20090: [FLINK-28269][Kubernetes] Install cri-dockerd and crictl so we can continue using driver `none` when running Kubernetes tests
Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #20090:
URL: https://github.com/apache/flink/pull/20090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org