[GitHub] [incubator-pinot] npawar commented on issue #4877: Results in ResultTable if responseFormat=sql

[GitBox <gi...@apache.org>]

npawar commented on issue #4877: Results in ResultTable if responseFormat=sql
URL: https://github.com/apache/incubator-pinot/pull/4877#issuecomment-561877634
 
 
   > LGTM. One high level comment:
   > 
   > I think it is fine to have a PQL flavor in SQL group by execution mode -- thus giving users to get results in both SQL (ResultTable) and PQL (for backward compatibility)
   > 
   > However, for PQL group by execution mode, we should probably consider not having any SQL flavor there. Currently we still allow the results to be in SQL if there is exactly one aggregation function and responseFormat is SQL even though the execution mode was PQL. If the user chose to use PQL, then everything (response, execution) should be PQL style.
   
   Yes that's fair. But it's good to have for now, because it helps migrate to sql response format, without losing support for group by entirely. I agree it doesn't read very well, and is confusing. Will evaluate if it makes sense to nuke that path

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org