[jira] [Commented] (PROTON-445) Binding installation ignores prefix

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911650#comment-13911650 ] 

ASF subversion and git services commented on PROTON-445:
--------------------------------------------------------

Commit 1571719 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1571719 ]

PROTON-445: Dynamic languages honor CMAKE_INSTALL_PREFIX

All languages are installed to $CMAKE_INSTALL_PREFIX/bindings/$LANG by
default.

If the ASK_ALL macro is set to 1 at the command line, then each
language is interrogated as to the location of where they will be
installed, and that path modified wit the install prefix.

Individual languages can be told to interrogate for the install path
with:

  ASK_[LANG]=1

> Binding installation ignores prefix
> -----------------------------------
>
>                 Key: PROTON-445
>                 URL: https://issues.apache.org/jira/browse/PROTON-445
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.5
>            Reporter: Justin Ross
>            Assignee: Darryl L. Pierce
>             Fix For: 0.7
>
>         Attachments: what-a-mess.txt
>
>
> It allows you *prepend* to the install prefix, but it gives you no way afaict to actually change the prefix.
> This is the opposite of nice.  If you set a prefix for your build *and* you try to get your bindings slotted in with them, via DESTDIR, you get this:
> # cmake -DCMAKE_INSTALL_PREFIX:PATH=/opt/myplace /var/tmp/jross/baker/proton/source
> # make install DESTDIR=/opt/myplace
> /opt/myplace/usr/lib/python/*python files*
> /opt/myplace/opt/myplace/lib/*c files*
> ^^ Note "/opt/myplace/opt/myplace", the first from DESTDIR, the second from CMAKE_INSTALL_PREFIX
> What it is doing now is simply abuse of DESTDIR.  DESTDIR is intended to be a mechanism for staged installs (packaging systems use this), and it cannot function correctly as an override for prefix.
> http://www.gnu.org/prep/standards/html_node/DESTDIR.html
> My proposed solution to this is to stop this madness: make the binding install honor CMAKE_INSTALL_PREFIX.  Let the developer be responsible for choosing the right location for his or her distribution.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)