You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/01/27 15:57:55 UTC

[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20854: [BUGFIX] Remove compilation warning

anko-intel commented on a change in pull request #20854:
URL: https://github.com/apache/incubator-mxnet/pull/20854#discussion_r793755181



##########
File path: src/operator/quantization/mkldnn/mkldnn_quantized_elemwise_add.cc
##########
@@ -135,7 +135,8 @@ static void MKLDNNQuantizedElemwiseAddForward(const nnvm::NodeAttrs& attrs,
     output_data_range = kUint8Range;
     output_data_type  = mkldnn::memory::data_type::u8;
   } else {
-    output_data_range = kInt32Range;
+    // The impact of rounding in line below is negligible.

Review comment:
       Good point! Thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org