You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by "anasoid (via GitHub)" <gi...@apache.org> on 2023/06/19 06:21:19 UTC
[GitHub] [jmeter] anasoid opened a new pull request, #5995: add negate ifcontroller 5994
anasoid opened a new pull request, #5995:
URL: https://github.com/apache/jmeter/pull/5995
## Description
Add negate checkbox to ifcontroller
Related to #5994
## Motivation and Context
it's an easy way to have if else by duplicating ifcontroller and check negate and in many case the negate value is more clear than real condition
## How Has This Been Tested?
Test are added to TestIfController.java to test :
1. default value not change the result (send sample)
2. negate true will not send sample
3. negate false will send sample
## Screenshots (if appropriate):
## Types of changes
- New feature (non-breaking change which adds functionality)
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ x] My code follows the [code style][style-guide] of this project.
- [ x] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi commented on pull request #5995: add negate ifcontroller 5994
Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi commented on PR #5995:
URL: https://github.com/apache/jmeter/pull/5995#issuecomment-1596583453
Thanks for working on this, however, I would rather approach https://github.com/apache/jmeter/issues/5981 first. I am afraid adding checkboxes like "invert" would make UI even more complicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi commented on pull request #5995: add negate ifcontroller 5994
Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi commented on PR #5995:
URL: https://github.com/apache/jmeter/pull/5995#issuecomment-1596648755
Should this PR and the issue be closed then?
Do you think you could work on https://github.com/apache/jmeter/issues/5981?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi closed pull request #5995: add negate ifcontroller 5994
Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi closed pull request #5995: add negate ifcontroller 5994
URL: https://github.com/apache/jmeter/pull/5995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] anasoid commented on pull request #5995: add negate ifcontroller 5994
Posted by "anasoid (via GitHub)" <gi...@apache.org>.
anasoid commented on PR #5995:
URL: https://github.com/apache/jmeter/pull/5995#issuecomment-1596597599
Agree #5981 will be more powerfull and easy to use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi commented on pull request #5995: add negate ifcontroller 5994
Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi commented on PR #5995:
URL: https://github.com/apache/jmeter/pull/5995#issuecomment-1598108237
Closing in favour of https://github.com/apache/jmeter/issues/5981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] anasoid commented on pull request #5995: add negate ifcontroller 5994
Posted by "anasoid (via GitHub)" <gi...@apache.org>.
anasoid commented on PR #5995:
URL: https://github.com/apache/jmeter/pull/5995#issuecomment-1596815216
yes we can close this PR and issue.
I can work on #5981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org