Re: [PR] [CELEBORN-914] Support memory file storage [celeborn]

["turboFei (via GitHub)" <gi...@apache.org>]

turboFei commented on code in PR #2300:
URL: https://github.com/apache/celeborn/pull/2300#discussion_r1838567234


##########
common/src/main/java/org/apache/celeborn/common/meta/MemoryFileInfo.java:
##########
@@ -17,19 +17,36 @@
 
 package org.apache.celeborn.common.meta;
 
+import java.util.*;
+
 import io.netty.buffer.CompositeByteBuf;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import org.apache.celeborn.common.identity.UserIdentifier;
+import org.apache.celeborn.common.util.ShuffleBlockInfoUtils.ShuffleBlockInfo;
 
 public class MemoryFileInfo extends FileInfo {
+  Logger logger = LoggerFactory.getLogger(MemoryFileInfo.class);
   private CompositeByteBuf buffer;
-  private long length;
+  private CompositeByteBuf sortedBuffer;

Review Comment:
   excuse me, how is the `sortedBuffer` released?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org