You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2015/05/26 17:47:13 UTC
[GitHub] flink pull request: [FLINK-2096] Remove implicit conversion from W...
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/726
[FLINK-2096] Remove implicit conversion from Window Stream to Stream
This causes unexpected behaviour, for example in:
ds.window(...).map(..)
The user would expect some kind of windowing to take place. The
windowing, however, cancels out with the implicitly inserted flatten()
call.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink stream-remove-implicit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/726.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #726
----
commit 93958593b96a2137b86de149c7a757ba4e08c428
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2015-05-26T15:44:21Z
[FLINK-2096] Remove implicit conversion from Window Stream to Stream
This causes unexpected behaviour, for example in:
ds.window(...).map(..)
The user would expect some kind of windowing to take place. The
windowing, however, cancels out with the implicitly inserted flatten()
call.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2096] Remove implicit conversion from W...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/726#issuecomment-106237798
manually merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2096] Remove implicit conversion from W...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/726#issuecomment-105598384
The reason for having this was that then the conversion is seamless. As seen in the relevant [question](http://stackoverflow.com/questions/30461809/in-flink-stream-windowing-does-not-seem-to-work) it can lead to unexpected behaviour, so I am for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2096] Remove implicit conversion from W...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/726
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2096] Remove implicit conversion from W...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/726#issuecomment-105841951
+1 from my side.
I think it is important that the core APIs let you see clearly what is happening, otherwise new users usually get thrown off.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---