You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kristian Waagan (JIRA)" <de...@db.apache.org> on 2006/07/17 14:26:14 UTC
[jira] Created: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
'setAsciiStream' uses different encodings for embedded and client
-----------------------------------------------------------------
Key: DERBY-1519
URL: http://issues.apache.org/jira/browse/DERBY-1519
Project: Derby
Issue Type: Bug
Components: JDBC, Network Client
Affects Versions: 10.1.3.1, 10.2.0.0
Reporter: Kristian Waagan
The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-1519:
-----------------------------------
Derby Info: [Release Note Needed]
Affects Version/s: 10.3.0.0
Ticked the "Release Note Needed" flag, and added 10.3 to the affected list.
I don't think the release note can be called fine, if people don't understand what it means. I'll have given it another try.
This time I deleted the old file, but what is the preferred way of publishing updates to the release note?
Must the file be named something special for the utility to pick it up?
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: https://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-1519-1a.diff, derby-1519-1a.stat
>
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-1519:
-----------------------------------
Derby Info: [Existing Application Impact] (was: [Release Note Needed])
Ticked "Existing Application Impact".
Thank you Myrna for your input on this, and for reading the release notes.
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: https://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: derby-1519-1a.diff, derby-1519-1a.stat, releaseNote.html, releaseNote.html
>
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-1519:
-----------------------------------
Attachment: releaseNote.html
Your comment makes a lot of sense Dan :) Thanks!
I have uploaded a third revision of the release notes. It is now considered done from my point of view, but others are free to change it if they feel the need to.
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: https://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: derby-1519-1a.diff, derby-1519-1a.stat, releaseNote.html, releaseNote.html
>
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499052 ]
Kristian Waagan commented on DERBY-1519:
----------------------------------------
Would people object to just changing the encoding in the client from US-ASCII to ISO-8859-1?
This would make Derby more compliant with JDBC, but could it also break existing applications?
I have checked that the change does not break any tests for Clob, but it remains to see if the same is true for PreparedStatement.setAsciiStream (on the client).
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: https://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Kristian Waagan
> Priority: Minor
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499451 ]
Knut Anders Hatlen commented on DERBY-1519:
-------------------------------------------
+1 to change the encoding on the client to ISO-8859-1. Sounds like a safe change that is not likely to break existing applications.
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: https://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Kristian Waagan
> Priority: Minor
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500598 ]
Kristian Waagan commented on DERBY-1519:
----------------------------------------
derbyall ran without failures.
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: https://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-1519-1a.diff, derby-1519-1a.stat
>
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan closed DERBY-1519.
----------------------------------
Since there has been no response on merging the fix with 10.2 and we have pushed 10.3 out the door, I'm closing this issue without merging it with the 10.2 branch.
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: https://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.3.1.4
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.1.4
>
> Attachments: derby-1519-1a.diff, derby-1519-1a.stat, releaseNote.html, releaseNote.html
>
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-1519:
-----------------------------------
Attachment: releaseNote.html
Second version of the release notes.
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: https://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-1519-1a.diff, derby-1519-1a.stat, releaseNote.html
>
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Daniel John Debrunner (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1519?page=all ]
Daniel John Debrunner updated DERBY-1519:
-----------------------------------------
Priority: Minor (was: Major)
Possible workaround is for the application to use getCharacterStream and apply encoding as required.
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: http://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.0.0
> Reporter: Kristian Waagan
> Priority: Minor
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506425 ]
Kristian Waagan commented on DERBY-1519:
----------------------------------------
This is an easy fix to merge into the 10.2 branch, but is that safe/correct to do?
If not, I will close this issue.
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: https://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: derby-1519-1a.diff, derby-1519-1a.stat, releaseNote.html, releaseNote.html
>
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by Kristian Waagan <Kr...@Sun.COM>.
Knut Anders Hatlen wrote:
> Kristian Waagan <Kr...@Sun.COM> writes:
>
>> Mike Matrigali wrote:
>>> From the description in the bug this seems like the right change, but
>>> it does seem like it may also be another incompatibility. Should it
>>> be added to the wiki? What difference will an app that somehow
>>> depended on the old (wrong) behavior see now?
>> I think the only difference is that where you previously inserted a
>> character outside US-ASCII and got a '?' back, you will now get the
>> actual character back.
>>
>> A typical example is the three "extra" Norwegian/Danish letters.
>>
>> So the patch might change what goes in and what comes back.
>> Personally I think people needing these characters are already using
>> setCharacterStream (or another mechanism handling the issue), and
>> would not be affected.
>> And people using only US-ASCII for input would not be affected either.
>> The only case where it can affect input/output is when the input is
>> something like ISO-8859-1, but as I said, I think this case is handled
>> differently by the users.
>>
>> Just my thoughts. There is maybe a slight incompatibility, but due to
>> its nature I think it is acceptable.
>>
>> So, what did I forget about? :)
>
> You could also have applications that pass the contents of a clob to a
> library/method that only knows how to handle US-ASCII. If
> getAsciiStream() starts using ISO-8859-1 (as it should), those
> applications could get strange errors because Derby previously would
> have masked non-US-ASCII characters as question marks. I don't think
> this is a blocker, but perhaps it would be appropriate with a release
> note?
>
I want to get this fix in due to tests for Clob, which breaks if this is
not fixed.
Can I get another opinion on the need for a release note?
I'm having a little trouble writing meaningful words in the various
sections, but I have added a draft to the Jira.
thanks,
--
Kristian
Re: [jira] Updated: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by Knut Anders Hatlen <Kn...@Sun.COM>.
Kristian Waagan <Kr...@Sun.COM> writes:
> Mike Matrigali wrote:
>> From the description in the bug this seems like the right change, but
>> it does seem like it may also be another incompatibility. Should it
>> be added to the wiki? What difference will an app that somehow
>> depended on the old (wrong) behavior see now?
>
> I think the only difference is that where you previously inserted a
> character outside US-ASCII and got a '?' back, you will now get the
> actual character back.
>
> A typical example is the three "extra" Norwegian/Danish letters.
>
> So the patch might change what goes in and what comes back.
> Personally I think people needing these characters are already using
> setCharacterStream (or another mechanism handling the issue), and
> would not be affected.
> And people using only US-ASCII for input would not be affected either.
> The only case where it can affect input/output is when the input is
> something like ISO-8859-1, but as I said, I think this case is handled
> differently by the users.
>
> Just my thoughts. There is maybe a slight incompatibility, but due to
> its nature I think it is acceptable.
>
> So, what did I forget about? :)
You could also have applications that pass the contents of a clob to a
library/method that only knows how to handle US-ASCII. If
getAsciiStream() starts using ISO-8859-1 (as it should), those
applications could get strange errors because Derby previously would
have masked non-US-ASCII characters as question marks. I don't think
this is a blocker, but perhaps it would be appropriate with a release
note?
--
Knut Anders
Re: [jira] Updated: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by Kristian Waagan <Kr...@Sun.COM>.
Mike Matrigali wrote:
> From the description in the bug this seems like the right change, but
> it does seem like it may also be another incompatibility. Should it
> be added to the wiki? What difference will an app that somehow depended
> on the old (wrong) behavior see now?
I think the only difference is that where you previously inserted a
character outside US-ASCII and got a '?' back, you will now get the
actual character back.
A typical example is the three "extra" Norwegian/Danish letters.
So the patch might change what goes in and what comes back.
Personally I think people needing these characters are already using
setCharacterStream (or another mechanism handling the issue), and would
not be affected.
And people using only US-ASCII for input would not be affected either.
The only case where it can affect input/output is when the input is
something like ISO-8859-1, but as I said, I think this case is handled
differently by the users.
Just my thoughts. There is maybe a slight incompatibility, but due to
its nature I think it is acceptable.
So, what did I forget about? :)
regards,
--
Kristian
>
> Kristian Waagan (JIRA) wrote:
>> [
>> https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Kristian Waagan updated DERBY-1519:
>> -----------------------------------
>>
>> Attachment: derby-1519-1a.stat
>> derby-1519-1a.diff
>>
>> 'derby-1519-1a.diff' changes all uses of US-ASCII on the client to
>> ISO-8859-1.
>> suites.All run without errors with Java 1.5, and I started a derbyall
>> now.
>>
>> Please raise your concerns if you have any, I will commit if the
>> second test run goes well.
>>
>>> 'setAsciiStream' uses different encodings for embedded and client
>>> -----------------------------------------------------------------
>>>
>>> Key: DERBY-1519
>>> URL: https://issues.apache.org/jira/browse/DERBY-1519
>>> Project: Derby
>>> Issue Type: Bug
>>> Components: JDBC, Network Client
>>> Affects Versions: 10.1.3.1, 10.2.1.6
>>> Reporter: Kristian Waagan
>>> Priority: Minor
>>> Attachments: derby-1519-1a.diff, derby-1519-1a.stat
>>>
>>>
>>> The JDBC method 'setAsciiStream' uses different encodings for
>>> embedded and client. In the embedded driver, "ISO-8859-1" is used, in
>>> the client driver "US-ASCII" is used. The former is 8-bit, the latter
>>> is 7-bit. According to JDBC, the 8-bit encoding should be used for
>>> ASCII (see
>>> http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29
>>> ).
>>> The method 'getAsciiStream' should also be made to match in the two
>>> drivers.
>>
Re: [jira] Updated: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by Mike Matrigali <mi...@sbcglobal.net>.
From the description in the bug this seems like the right change, but
it does seem like it may also be another incompatibility. Should it
be added to the wiki? What difference will an app that somehow depended
on the old (wrong) behavior see now?
Kristian Waagan (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Kristian Waagan updated DERBY-1519:
> -----------------------------------
>
> Attachment: derby-1519-1a.stat
> derby-1519-1a.diff
>
> 'derby-1519-1a.diff' changes all uses of US-ASCII on the client to ISO-8859-1.
> suites.All run without errors with Java 1.5, and I started a derbyall now.
>
> Please raise your concerns if you have any, I will commit if the second test run goes well.
>
>> 'setAsciiStream' uses different encodings for embedded and client
>> -----------------------------------------------------------------
>>
>> Key: DERBY-1519
>> URL: https://issues.apache.org/jira/browse/DERBY-1519
>> Project: Derby
>> Issue Type: Bug
>> Components: JDBC, Network Client
>> Affects Versions: 10.1.3.1, 10.2.1.6
>> Reporter: Kristian Waagan
>> Priority: Minor
>> Attachments: derby-1519-1a.diff, derby-1519-1a.stat
>>
>>
>> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
>> The method 'getAsciiStream' should also be made to match in the two drivers.
>
[jira] Updated: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-1519:
-----------------------------------
Attachment: derby-1519-1a.stat
derby-1519-1a.diff
'derby-1519-1a.diff' changes all uses of US-ASCII on the client to ISO-8859-1.
suites.All run without errors with Java 1.5, and I started a derbyall now.
Please raise your concerns if you have any, I will commit if the second test run goes well.
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: https://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Kristian Waagan
> Priority: Minor
> Attachments: derby-1519-1a.diff, derby-1519-1a.stat
>
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren updated DERBY-1519:
--------------------------------------
Derby Info: [Existing Application Impact, Release Note Needed] (was: [Existing Application Impact])
adding 'Release Note Needed' flag so this gets picked up by the ReleaseNotesGenerator.
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: https://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: derby-1519-1a.diff, derby-1519-1a.stat, releaseNote.html, releaseNote.html
>
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-1519:
-----------------------------------
Attachment: releaseNote.html
Draft of a potential release note, if required. Checkbox for release note not ticked yet...
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: https://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-1519-1a.diff, derby-1519-1a.stat, releaseNote.html
>
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan resolved DERBY-1519.
------------------------------------
Resolution: Fixed
Fix Version/s: 10.3.0.0
Committed 'derby-1519-1a.diff' to trunk with revision 544424. Ran suites.All with Java 1.5 again cleanly.
Based on the possible incompatibilities, I suppose the right think to do is not to merge this with the 10.2 (or 10.1) branch?
Should we also tick the existing application impact?
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: https://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: derby-1519-1a.diff, derby-1519-1a.stat, releaseNote.html
>
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501267 ]
Myrna van Lunteren commented on DERBY-1519:
-------------------------------------------
The release note looks fine, except for the 'obtain' in the summary I
think should be 'obtained'.
I guess I don't really understand the possible impact.
Would the same characters would now be displayed whereas previously
you'd see question marks? Isn't whether you see question marks or not
depending on the console encoding you have set?
Or is the actual difference something else?
It seems to me wiser to add a release note for a possible incompatibility.
Myrna
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: https://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-1519-1a.diff, derby-1519-1a.stat, releaseNote.html
>
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Daniel John Debrunner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501614 ]
Daniel John Debrunner commented on DERBY-1519:
----------------------------------------------
The change is only for the client driver correct? If so the release note should be explicit about that.
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: https://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: derby-1519-1a.diff, derby-1519-1a.stat, releaseNote.html
>
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan reassigned DERBY-1519:
--------------------------------------
Assignee: Kristian Waagan
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: https://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-1519-1a.diff, derby-1519-1a.stat
>
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-1519:
-----------------------------------
Attachment: (was: releaseNote.html)
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: https://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-1519-1a.diff, derby-1519-1a.stat
>
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1519) 'setAsciiStream' uses different
encodings for embedded and client
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501612 ]
Myrna van Lunteren commented on DERBY-1519:
-------------------------------------------
The new release note is more explicit, I like it.
The release note file has to be named releaseNote.html.
The release note generator (see DERBY-2750) will figure out the latest
file of that name & pick that one, so you don't need to remove the old
one.
The release note generator will pick up the release notes whenever
it's marked release note needed or existing application impact, but
some people have ticked release note needed off when they attach a
release note, and leave existing application impact on.
So, probably best to tick 'application impact'.
Myrna
> 'setAsciiStream' uses different encodings for embedded and client
> -----------------------------------------------------------------
>
> Key: DERBY-1519
> URL: https://issues.apache.org/jira/browse/DERBY-1519
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: derby-1519-1a.diff, derby-1519-1a.stat, releaseNote.html
>
>
> The JDBC method 'setAsciiStream' uses different encodings for embedded and client. In the embedded driver, "ISO-8859-1" is used, in the client driver "US-ASCII" is used. The former is 8-bit, the latter is 7-bit. According to JDBC, the 8-bit encoding should be used for ASCII (see http://db.apache.org/derby/papers/JDBCImplementation.html#GetAsciiStream%28%29 ).
> The method 'getAsciiStream' should also be made to match in the two drivers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.