You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "davidhcoe (via GitHub)" <gi...@apache.org> on 2023/09/04 14:53:18 UTC
[GitHub] [arrow-adbc] davidhcoe opened a new pull request, #1034: feat(go/adbc/driver/snowflake): add XDBC support
davidhcoe opened a new pull request, #1034:
URL: https://github.com/apache/arrow-adbc/pull/1034
Enhance XDBC values for Snowflake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on a diff in pull request #1034: feat(go/adbc/driver/snowflake): improve XDBC support
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #1034:
URL: https://github.com/apache/arrow-adbc/pull/1034#discussion_r1316087805
##########
go/adbc/driver/snowflake/connection.go:
##########
@@ -967,3 +1057,34 @@ func (c *cnxn) SetOptionDouble(key string, value float64) error {
Code: adbc.StatusNotImplemented,
}
}
+
+// The JDBC/ODBC-defined type of any object.
+// All the values here are the sames as in the JDBC and ODBC specs.
+type XdbcDataType int32
+
+const (
+ XdbcDataType_XDBC_UNKNOWN_TYPE XdbcDataType = 0
+ XdbcDataType_XDBC_CHAR XdbcDataType = 1
+ XdbcDataType_XDBC_NUMERIC XdbcDataType = 2
+ XdbcDataType_XDBC_DECIMAL XdbcDataType = 3
+ XdbcDataType_XDBC_INTEGER XdbcDataType = 4
+ XdbcDataType_XDBC_SMALLINT XdbcDataType = 5
+ XdbcDataType_XDBC_FLOAT XdbcDataType = 6
+ XdbcDataType_XDBC_REAL XdbcDataType = 7
+ XdbcDataType_XDBC_DOUBLE XdbcDataType = 8
+ XdbcDataType_XDBC_DATETIME XdbcDataType = 9
+ XdbcDataType_XDBC_INTERVAL XdbcDataType = 10
+ XdbcDataType_XDBC_VARCHAR XdbcDataType = 12
+ XdbcDataType_XDBC_DATE XdbcDataType = 91
+ XdbcDataType_XDBC_TIME XdbcDataType = 92
+ XdbcDataType_XDBC_TIMESTAMP XdbcDataType = 93
+ XdbcDataType_XDBC_LONGVARCHAR XdbcDataType = -1
+ XdbcDataType_XDBC_BINARY XdbcDataType = -2
+ XdbcDataType_XDBC_VARBINARY XdbcDataType = -3
+ XdbcDataType_XDBC_LONGVARBINARY XdbcDataType = -4
+ XdbcDataType_XDBC_BIGINT XdbcDataType = -5
+ XdbcDataType_XDBC_TINYINT XdbcDataType = -6
+ XdbcDataType_XDBC_BIT XdbcDataType = -7
+ XdbcDataType_XDBC_WCHAR XdbcDataType = -8
+ XdbcDataType_XDBC_WVARCHAR XdbcDataType = -9
+)
Review Comment:
Might be worthwhile for these to be in the shared_utils.go file also so that other drivers can use them too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] davidhcoe commented on pull request #1034: feat(go/adbc/driver/snowflake): improve XDBC support
Posted by "davidhcoe (via GitHub)" <gi...@apache.org>.
davidhcoe commented on PR #1034:
URL: https://github.com/apache/arrow-adbc/pull/1034#issuecomment-1718382876
added tests for xdbc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade merged pull request #1034: feat(go/adbc/driver/snowflake): improve XDBC support
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #1034:
URL: https://github.com/apache/arrow-adbc/pull/1034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on pull request #1034: feat(go/adbc/driver/snowflake): improve XDBC support
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #1034:
URL: https://github.com/apache/arrow-adbc/pull/1034#issuecomment-1709028857
Could you add a few tests to the `driver_test.go` unit tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] davidhcoe commented on pull request #1034: feat(go/adbc/driver/snowflake): improve XDBC support
Posted by "davidhcoe (via GitHub)" <gi...@apache.org>.
davidhcoe commented on PR #1034:
URL: https://github.com/apache/arrow-adbc/pull/1034#issuecomment-1708936016
> LGTM in general, can you add any tests for these? In general the tests for snowflake wont' run unless the env vars are set (which means it won't run on the PR here, but can be run manually if the env var is set).
It seems like these would plug in to a GetObjects test, which we have in https://github.com/apache/arrow-adbc/pull/1031, but I don't see any in the driver directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org