You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/28 17:28:54 UTC

[GitHub] [cloudstack] nvazquez opened a new pull request #6175: KVM: Enhance CPU speed detection on hosts

nvazquez opened a new pull request #6175:
URL: https://github.com/apache/cloudstack/pull/6175


   ### Description
   
   This PR does two things:
   
   1. In a recent commit the way host CPU speed is detected was changed to use `lscpu`. This is a great enhancement, but it changed the detected speed from being the host's max turbo frequency to being the base clock. I agree this is the ideal speed to use since the max turbo frequency usually is not achieved by all cores at once. To ensure the fallback of using `cpufreq` files matches this behavior, we change the fallback to look at the `base_frequency` file rather than `cpuinfo_max_freq`.
   
   2. Introduce agent.properties setting `host.cpu.manual.speed.mhz` to allow the admin to set the frequency in case all else fails.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #6175: KVM: Enhance CPU speed detection on hosts

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #6175:
URL: https://github.com/apache/cloudstack/pull/6175#discussion_r838319844



##########
File path: agent/conf/agent.properties
##########
@@ -285,3 +285,6 @@ iscsi.session.cleanup.enabled=false
 
 # Enable manually setting CPU's topology on KVM's VM.
 # enable.manually.setting.cpu.topology.on.kvm.vm=true
+
+# host.cpu.manual.speed.mhz = int
+# Manually set the host CPU MHz, in cases where CPU scaling support detected value is wrong

Review comment:
       ```suggestion
   # Manually set the host CPU MHz, in cases where CPU scaling support detected value is wrong
   # host.cpu.manual.speed.mhz=0
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6175: KVM: Enhance CPU speed detection on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6175:
URL: https://github.com/apache/cloudstack/pull/6175#issuecomment-1081835121


   @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #6175: KVM: Enhance CPU speed detection on hosts

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6175:
URL: https://github.com/apache/cloudstack/pull/6175#issuecomment-1081834637


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6175: KVM: Enhance CPU speed detection on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6175:
URL: https://github.com/apache/cloudstack/pull/6175#issuecomment-1082416272


   <b>Trillian test result (tid-3752)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31689 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6175-t3752-kvm-centos7.zip
   Smoke tests completed. 92 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #6175: KVM: Enhance CPU speed detection on hosts

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6175:
URL: https://github.com/apache/cloudstack/pull/6175#issuecomment-1081835977


   @blueorangutan test ubuntu20 kvm-ubuntu20


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6175: KVM: Enhance CPU speed detection on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6175:
URL: https://github.com/apache/cloudstack/pull/6175#issuecomment-1081829570


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3007


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #6175: KVM: Enhance CPU speed detection on hosts

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6175:
URL: https://github.com/apache/cloudstack/pull/6175#issuecomment-1085950349


   Thanks @DaanHoogland - fixed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #6175: KVM: Enhance CPU speed detection on hosts

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #6175:
URL: https://github.com/apache/cloudstack/pull/6175#discussion_r838255238



##########
File path: agent/conf/agent.properties
##########
@@ -285,3 +285,6 @@ iscsi.session.cleanup.enabled=false
 
 # Enable manually setting CPU's topology on KVM's VM.
 # enable.manually.setting.cpu.topology.on.kvm.vm=true
+
+# host.cpu.manual.speed.mhz = int
+# Manually set the host CPU MHz, in cases where CPU scaling support detected value is wrong

Review comment:
       should we adhere to the convention of putting the explaining comment before the commented default value?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #6175: KVM: Enhance CPU speed detection on hosts

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6175:
URL: https://github.com/apache/cloudstack/pull/6175#issuecomment-1081793145


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez merged pull request #6175: KVM: Enhance CPU speed detection on hosts

Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #6175:
URL: https://github.com/apache/cloudstack/pull/6175


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6175: KVM: Enhance CPU speed detection on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6175:
URL: https://github.com/apache/cloudstack/pull/6175#issuecomment-1081794968


   @Pearl1594 a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org