You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "E. Sammer (Created) (JIRA)" <ji...@apache.org> on 2011/10/22 22:56:32 UTC
[jira] [Created] (FLUME-814) Add support for multiple channels to
sources
Add support for multiple channels to sources
--------------------------------------------
Key: FLUME-814
URL: https://issues.apache.org/jira/browse/FLUME-814
Project: Flume
Issue Type: New Feature
Components: Sinks+Sources
Affects Versions: NG alpha 1
Reporter: E. Sammer
Fix For: NG alpha 2
Flume NG's architecture and configuration claim sources support multiple channels but this isn't currently true. The current implementation limits sources to a single channel which precludes fanout behavior.
This will be a fairly invasive change as it impacts the Source interface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FLUME-814) Add support for multiple channels to
sources
Posted by "Prasad Mujumdar (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Mujumdar reassigned FLUME-814:
-------------------------------------
Assignee: Prasad Mujumdar
> Add support for multiple channels to sources
> --------------------------------------------
>
> Key: FLUME-814
> URL: https://issues.apache.org/jira/browse/FLUME-814
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: E. Sammer
> Assignee: Prasad Mujumdar
> Fix For: NG alpha 2
>
>
> Flume NG's architecture and configuration claim sources support multiple channels but this isn't currently true. The current implementation limits sources to a single channel which precludes fanout behavior.
> This will be a fairly invasive change as it impacts the Source interface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-814) Add support for multiple channels to
sources
Posted by "Prasad Mujumdar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Mujumdar updated FLUME-814:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to flume-728
> Add support for multiple channels to sources
> --------------------------------------------
>
> Key: FLUME-814
> URL: https://issues.apache.org/jira/browse/FLUME-814
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: E. Sammer
> Assignee: Prasad Mujumdar
> Fix For: NG alpha 2
>
> Attachments: FLUME-814.patch
>
>
> Flume NG's architecture and configuration claim sources support multiple channels but this isn't currently true. The current implementation limits sources to a single channel which precludes fanout behavior.
> This will be a fairly invasive change as it impacts the Source interface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-814) Add support for multiple channels to
sources
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160498#comment-13160498 ]
jiraposter@reviews.apache.org commented on FLUME-814:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2701/
-----------------------------------------------------------
(Updated 2011-12-01 00:22:45.995318)
Review request for Arvind Prabhakar and Eric Sammer.
Changes
-------
Update the patch to maintain consistent state for enclosed transactions in error cases.
Summary
-------
A new fanout channel is added that contains list of underlying channels and performs the given operation on all those. A new method added to channelfactory to create the fanout channel from a list of channels. One can specify a comma separated list of channels for a sink to create the fanout
This addresses bug Flume-814.
https://issues.apache.org/jira/browse/Flume-814
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/ChannelFactory.java 23194a9
flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 8a3ec56
flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java 4d8313f
flume-ng-core/src/test/java/org/apache/flume/channel/TestFanoutChannel.java PRE-CREATION
flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 975eafd
flume-ng-node/src/main/java/org/apache/flume/node/Application.java 8b93e59
Diff: https://reviews.apache.org/r/2701/diff
Testing
-------
ran all unit tests, added new test for the fanout channel
Thanks,
Prasad
> Add support for multiple channels to sources
> --------------------------------------------
>
> Key: FLUME-814
> URL: https://issues.apache.org/jira/browse/FLUME-814
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: E. Sammer
> Assignee: Prasad Mujumdar
> Fix For: NG alpha 2
>
> Attachments: FLUME-814.patch
>
>
> Flume NG's architecture and configuration claim sources support multiple channels but this isn't currently true. The current implementation limits sources to a single channel which precludes fanout behavior.
> This will be a fairly invasive change as it impacts the Source interface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-814) Add support for multiple channels to
sources
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160232#comment-13160232 ]
jiraposter@reviews.apache.org commented on FLUME-814:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2701/#review3586
-----------------------------------------------------------
Ship it!
Hi Prasad, my apologies for jumping in late on this review. I have some feedback below. Considering the time elapsed on this issue, I am ok with going ahead with the commit and opening follow-up JIRAs to track the issues highlighted.
flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java
<https://reviews.apache.org/r/2701/#comment7998>
This can lead to inconsistencies. Calling a roll-back (or any other method) on a transaction that has not yet begun could lead to leaks.
flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java
<https://reviews.apache.org/r/2701/#comment7999>
Same as before - calling a close on a transaction that has not begun will lead to other problems.
- Arvind
On 2011-11-03 22:57:15, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2701/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-03 22:57:15)
bq.
bq.
bq. Review request for Arvind Prabhakar and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. A new fanout channel is added that contains list of underlying channels and performs the given operation on all those. A new method added to channelfactory to create the fanout channel from a list of channels. One can specify a comma separated list of channels for a sink to create the fanout
bq.
bq.
bq. This addresses bug Flume-814.
bq. https://issues.apache.org/jira/browse/Flume-814
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/ChannelFactory.java 23194a9
bq. flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java a41085f
bq. flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java PRE-CREATION
bq. flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java 4d8313f
bq. flume-ng-core/src/test/java/org/apache/flume/channel/TestFanoutChannel.java PRE-CREATION
bq. flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 975eafd
bq. flume-ng-node/src/main/java/org/apache/flume/node/Application.java 4004cba
bq.
bq. Diff: https://reviews.apache.org/r/2701/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. ran all unit tests, added new test for the fanout channel
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Add support for multiple channels to sources
> --------------------------------------------
>
> Key: FLUME-814
> URL: https://issues.apache.org/jira/browse/FLUME-814
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: E. Sammer
> Assignee: Prasad Mujumdar
> Fix For: NG alpha 2
>
> Attachments: FLUME-814.patch
>
>
> Flume NG's architecture and configuration claim sources support multiple channels but this isn't currently true. The current implementation limits sources to a single channel which precludes fanout behavior.
> This will be a fairly invasive change as it impacts the Source interface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-814) Add support for multiple channels to
sources
Posted by "Prasad Mujumdar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Mujumdar updated FLUME-814:
----------------------------------
Attachment: FLUME-814.patch
> Add support for multiple channels to sources
> --------------------------------------------
>
> Key: FLUME-814
> URL: https://issues.apache.org/jira/browse/FLUME-814
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: E. Sammer
> Assignee: Prasad Mujumdar
> Fix For: NG alpha 2
>
> Attachments: FLUME-814.patch
>
>
> Flume NG's architecture and configuration claim sources support multiple channels but this isn't currently true. The current implementation limits sources to a single channel which precludes fanout behavior.
> This will be a fairly invasive change as it impacts the Source interface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-814) Add support for multiple channels to
sources
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143311#comment-13143311 ]
jiraposter@reviews.apache.org commented on FLUME-814:
-----------------------------------------------------
bq. On 2011-11-03 15:58:19, Eric Sammer wrote:
bq. > This is probably a nicer approach than what we originally discussed; having the source take a list of channels. My concern is the implementation of take(). To take another step back, it actually doesn't make sense to take from a fan out channel at all. If we follow this path toward fan out functionality, should we instead throw UnsupportedOperationException from take() and disallow the (otherwise odd) behavior of discarding messages from the fan out?
bq. >
bq. > I can't think of any, but does this affect the failure scenarios in any way? We know we're not atomic across channels but are there any other concerns here?
bq. >
bq. > I have some naming / implementation nits, but otherwise I think this makes sense provided I can convince myself we're not doing anything bad here.
I agree about the take. The only reason I implemented it that way is for tests. In fact my original approach was to add a fanout channel by default to every sink. Most of the existing tests would have run into problems if it doesn't have put(). With the current approach, we can safely disable talk(). I will go ahead and make that change.
Please let me know your other comments, I would like to address those as well.
thanks
Prasad
- Prasad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2701/#review3026
-----------------------------------------------------------
On 2011-11-03 05:13:00, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2701/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-03 05:13:00)
bq.
bq.
bq. Review request for Arvind Prabhakar and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. A new fanout channel is added that contains list of underlying channels and performs the given operation on all those. A new method added to channelfactory to create the fanout channel from a list of channels. One can specify a comma separated list of channels for a sink to create the fanout
bq.
bq.
bq. This addresses bug Flume-814.
bq. https://issues.apache.org/jira/browse/Flume-814
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/ChannelFactory.java 23194a9
bq. flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java a41085f
bq. flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java PRE-CREATION
bq. flume-ng-core/src/test/java/org/apache/flume/channel/TestFanoutChannel.java PRE-CREATION
bq. flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 975eafd
bq. flume-ng-node/src/main/java/org/apache/flume/node/Application.java 4004cba
bq.
bq. Diff: https://reviews.apache.org/r/2701/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. ran all unit tests, added new test for the fanout channel
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Add support for multiple channels to sources
> --------------------------------------------
>
> Key: FLUME-814
> URL: https://issues.apache.org/jira/browse/FLUME-814
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: E. Sammer
> Assignee: Prasad Mujumdar
> Fix For: NG alpha 2
>
>
> Flume NG's architecture and configuration claim sources support multiple channels but this isn't currently true. The current implementation limits sources to a single channel which precludes fanout behavior.
> This will be a fairly invasive change as it impacts the Source interface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-814) Add support for multiple channels to
sources
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142844#comment-13142844 ]
jiraposter@reviews.apache.org commented on FLUME-814:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2701/
-----------------------------------------------------------
Review request for Arvind Prabhakar and Eric Sammer.
Summary
-------
A new fanout channel is added that contains list of underlying channels and performs the given operation on all those. A new method added to channelfactory to create the fanout channel from a list of channels. One can specify a comma separated list of channels for a sink to create the fanout
This addresses bug Flume-814.
https://issues.apache.org/jira/browse/Flume-814
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/ChannelFactory.java 23194a9
flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java a41085f
flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java PRE-CREATION
flume-ng-core/src/test/java/org/apache/flume/channel/TestFanoutChannel.java PRE-CREATION
flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 975eafd
flume-ng-node/src/main/java/org/apache/flume/node/Application.java 4004cba
Diff: https://reviews.apache.org/r/2701/diff
Testing
-------
ran all unit tests, added new test for the fanout channel
Thanks,
Prasad
> Add support for multiple channels to sources
> --------------------------------------------
>
> Key: FLUME-814
> URL: https://issues.apache.org/jira/browse/FLUME-814
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: E. Sammer
> Assignee: Prasad Mujumdar
> Fix For: NG alpha 2
>
>
> Flume NG's architecture and configuration claim sources support multiple channels but this isn't currently true. The current implementation limits sources to a single channel which precludes fanout behavior.
> This will be a fairly invasive change as it impacts the Source interface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-814) Add support for multiple channels to
sources
Posted by "Prasad Mujumdar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Mujumdar updated FLUME-814:
----------------------------------
Status: Patch Available (was: Open)
> Add support for multiple channels to sources
> --------------------------------------------
>
> Key: FLUME-814
> URL: https://issues.apache.org/jira/browse/FLUME-814
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: E. Sammer
> Assignee: Prasad Mujumdar
> Fix For: NG alpha 2
>
> Attachments: FLUME-814.patch
>
>
> Flume NG's architecture and configuration claim sources support multiple channels but this isn't currently true. The current implementation limits sources to a single channel which precludes fanout behavior.
> This will be a fairly invasive change as it impacts the Source interface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-814) Add support for multiple channels to
sources
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143262#comment-13143262 ]
jiraposter@reviews.apache.org commented on FLUME-814:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2701/#review3026
-----------------------------------------------------------
This is probably a nicer approach than what we originally discussed; having the source take a list of channels. My concern is the implementation of take(). To take another step back, it actually doesn't make sense to take from a fan out channel at all. If we follow this path toward fan out functionality, should we instead throw UnsupportedOperationException from take() and disallow the (otherwise odd) behavior of discarding messages from the fan out?
I can't think of any, but does this affect the failure scenarios in any way? We know we're not atomic across channels but are there any other concerns here?
I have some naming / implementation nits, but otherwise I think this makes sense provided I can convince myself we're not doing anything bad here.
- Eric
On 2011-11-03 05:13:00, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2701/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-03 05:13:00)
bq.
bq.
bq. Review request for Arvind Prabhakar and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. A new fanout channel is added that contains list of underlying channels and performs the given operation on all those. A new method added to channelfactory to create the fanout channel from a list of channels. One can specify a comma separated list of channels for a sink to create the fanout
bq.
bq.
bq. This addresses bug Flume-814.
bq. https://issues.apache.org/jira/browse/Flume-814
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/ChannelFactory.java 23194a9
bq. flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java a41085f
bq. flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java PRE-CREATION
bq. flume-ng-core/src/test/java/org/apache/flume/channel/TestFanoutChannel.java PRE-CREATION
bq. flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 975eafd
bq. flume-ng-node/src/main/java/org/apache/flume/node/Application.java 4004cba
bq.
bq. Diff: https://reviews.apache.org/r/2701/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. ran all unit tests, added new test for the fanout channel
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Add support for multiple channels to sources
> --------------------------------------------
>
> Key: FLUME-814
> URL: https://issues.apache.org/jira/browse/FLUME-814
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: E. Sammer
> Assignee: Prasad Mujumdar
> Fix For: NG alpha 2
>
>
> Flume NG's architecture and configuration claim sources support multiple channels but this isn't currently true. The current implementation limits sources to a single channel which precludes fanout behavior.
> This will be a fairly invasive change as it impacts the Source interface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-814) Add support for multiple channels to
sources
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143584#comment-13143584 ]
jiraposter@reviews.apache.org commented on FLUME-814:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2701/
-----------------------------------------------------------
(Updated 2011-11-03 22:57:15.522159)
Review request for Arvind Prabhakar and Eric Sammer.
Changes
-------
Changed take() to throw exception always. Added more error handling for fanout transaction and test cases.
Summary
-------
A new fanout channel is added that contains list of underlying channels and performs the given operation on all those. A new method added to channelfactory to create the fanout channel from a list of channels. One can specify a comma separated list of channels for a sink to create the fanout
This addresses bug Flume-814.
https://issues.apache.org/jira/browse/Flume-814
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/ChannelFactory.java 23194a9
flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java a41085f
flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java 4d8313f
flume-ng-core/src/test/java/org/apache/flume/channel/TestFanoutChannel.java PRE-CREATION
flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 975eafd
flume-ng-node/src/main/java/org/apache/flume/node/Application.java 4004cba
Diff: https://reviews.apache.org/r/2701/diff
Testing
-------
ran all unit tests, added new test for the fanout channel
Thanks,
Prasad
> Add support for multiple channels to sources
> --------------------------------------------
>
> Key: FLUME-814
> URL: https://issues.apache.org/jira/browse/FLUME-814
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: E. Sammer
> Assignee: Prasad Mujumdar
> Fix For: NG alpha 2
>
>
> Flume NG's architecture and configuration claim sources support multiple channels but this isn't currently true. The current implementation limits sources to a single channel which precludes fanout behavior.
> This will be a fairly invasive change as it impacts the Source interface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-814) Add support for multiple channels to
sources
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160584#comment-13160584 ]
Hudson commented on FLUME-814:
------------------------------
Integrated in flume-728 #64 (See [https://builds.apache.org/job/flume-728/64/])
Flume-814. Fanout channel support
> Add support for multiple channels to sources
> --------------------------------------------
>
> Key: FLUME-814
> URL: https://issues.apache.org/jira/browse/FLUME-814
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: E. Sammer
> Assignee: Prasad Mujumdar
> Fix For: NG alpha 2
>
> Attachments: FLUME-814.patch
>
>
> Flume NG's architecture and configuration claim sources support multiple channels but this isn't currently true. The current implementation limits sources to a single channel which precludes fanout behavior.
> This will be a fairly invasive change as it impacts the Source interface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira