[GitHub] [netbeans-tools] lkishalmi commented on a change in pull request #48: Create NetBeans Snap Distribution from Source with Snap core18

[GitBox <gi...@apache.org>]

lkishalmi commented on a change in pull request #48:
URL: https://github.com/apache/netbeans-tools/pull/48#discussion_r807055104



##########
File path: snap-packages/launchers/nbjavac-cleanup
##########
@@ -0,0 +1,8 @@
+#!/bin/sh
+
+# Remove externally installed nbjavac references from the userdir
+find ${SNAP_USER_DATA} -name '*nbjavac.*' -delete || true

Review comment:
       Yes. I think only if they are not exists. So when someone upgrades from 12.6 (rev: 52) to 13-rc3 (rev: 56), then the user home at ```$HOME/snap/netbeans/52``` is copied over to  ```$HOME/snap/netbeans/56``` automatically before the next start of the IDE. If the user decides, that the update was not successful, and whishes to go back to the previously installed version by using ```snap revert netbeans``` it won't copy anything, but ```$HOME/snap/netbeans/52``` would be used as USER_HOME again (and of course the old cache dir)
   So this is an optimistic auto-upgrade strategy, which lets the user go back to a previously known good state if the upgraded version does not meet the expectations.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists