You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "kenhuuu (via GitHub)" <gi...@apache.org> on 2023/06/05 19:53:36 UTC
[GitHub] [tinkerpop] kenhuuu opened a new pull request, #2086: Add gremlin-java8.bat for Java 8 Windows Console users.
kenhuuu opened a new pull request, #2086:
URL: https://github.com/apache/tinkerpop/pull/2086
The gremlin.bat file no longer works for users of Java 8 due to some changes in how pathing is determined in Groovy. This bat file finds all jars in lib and ext rather than using the * wildcard as that no longer works in Groovy. Because of the hard limit on the length of a variable for commands, relative paths had to be used instead of absolute paths. Although the use of relative paths for the -cp option is discouraged by Java, it is necessary in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] kenhuuu merged pull request #2086: Add gremlin-java8.bat for Java 8 Windows Console users.
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu merged PR #2086:
URL: https://github.com/apache/tinkerpop/pull/2086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #2086: Add gremlin-java8.bat for Java 8 Windows Console users.
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette commented on PR #2086:
URL: https://github.com/apache/tinkerpop/pull/2086#issuecomment-1577403476
i can't test, but the reasoning makes sense to me and i'm fine with the approach. VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer commented on pull request #2086: Add gremlin-java8.bat for Java 8 Windows Console users.
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2086:
URL: https://github.com/apache/tinkerpop/pull/2086#issuecomment-1577555531
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #2086: Add gremlin-java8.bat for Java 8 Windows Console users.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2086:
URL: https://github.com/apache/tinkerpop/pull/2086#issuecomment-1577445874
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2086?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2086](https://app.codecov.io/gh/apache/tinkerpop/pull/2086?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7fa1ce6) into [3.5-dev](https://app.codecov.io/gh/apache/tinkerpop/commit/d8cff12eb0ff47a2c1fb8a86a0a3496f35f8b0f7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d8cff12) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.5-dev #2086 +/- ##
=============================================
- Coverage 69.40% 69.40% -0.01%
+ Complexity 8982 8977 -5
=============================================
Files 866 866
Lines 41251 41251
Branches 5442 5442
=============================================
- Hits 28631 28630 -1
+ Misses 10716 10711 -5
- Partials 1904 1910 +6
```
[see 7 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2086/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org