[jira] [Created] (IMPALA-12311) Extra newlines are produced when an end-to-end test is run with update_results

["Fang-Yu Rao (Jira)" <ji...@apache.org>]

Fang-Yu Rao created IMPALA-12311:
------------------------------------

             Summary: Extra newlines are produced when an end-to-end test is run with update_results 
                 Key: IMPALA-12311
                 URL: https://issues.apache.org/jira/browse/IMPALA-12311
             Project: IMPALA
          Issue Type: Bug
            Reporter: Fang-Yu Rao
            Assignee: Fang-Yu Rao


We found that extra newlines are produced in the updated golden file when the actual results do not match the expected results specified in the original golden file.

Take [TestDecimalExprs::test_exprs()|https://github.com/apache/impala/blob/master/tests/query_test/test_decimal_queries.py#L75] for example, this test runs the test cases in [decimal-exprs.test|https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test].

Suppose that we modify the expected error message at [https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test#L107] from "UDF WARNING: Decimal expression overflowed, returning NULL" to the following (the original string with an additional "x").
{noformat}
UDF WARNING: Decimal expression overflowed, returning NULLx
{noformat}
Then we run this test using the following command with the command line argument '--update_results'.
{code:java}
$IMPALA_HOME/bin/impala-py.test \
--update_results \
--junitxml=$IMPALA_EE_TEST_LOGS_DIR/results/test_decimal.xml \
$IMPALA_HOME/tests/query_test/test_decimal_queries.py::TestDecimalExprs::test_exprs
{code}
In $IMPALA_HOME/logs/ee_tests/QueryTest_decimal-exprs.test, we will found the following subsection corresponding to the query. There are 3 additional newlines in the subsection of 'ERRORS'.
{noformat}
---- ERRORS
UDF WARNING: Decimal expression overflowed, returning NULL



====
{noformat}
One of the newlines was produced in [join_section_lines()|https://github.com/apache/impala/blob/master/tests/util/test_file_parser.py#L298]. This function is called when the actual results do not match the expected results in the following 4 places.
 # [test_section['ERRORS'] = join_section_lines(actual_errors)|https://github.com/apache/impala/blob/master/tests/common/test_result_verifier.py#L398].
 # [test_section['TYPES'] = join_section_lines([', '.join(actual_types)])|https://github.com/apache/impala/blob/master/tests/common/test_result_verifier.py#L429].
 # [test_section['LABELS'] = join_section_lines([', '.join(actual_labels)])|https://github.com/apache/impala/blob/master/tests/common/test_result_verifier.py#L451].
 # [test_section[result_section] = join_section_lines(actual.result_list)|https://github.com/apache/impala/blob/master/tests/common/test_result_verifier.py#L489].

Thus, we also have the same issue for subsections like TYPES, LABELS, and RESULTS in such a scenario (actual results do not match expected ones). It would be good if a user/developer does not have to manually remove those extra newlines when trying to generate the golden files for new test files.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org