You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/06/12 09:07:37 UTC

[GitHub] [pulsar] massakam opened a new pull request #4519: [pulsar-client-cpp] Make it possible to compile binary statically linked with log4cxx

massakam opened a new pull request #4519: [pulsar-client-cpp] Make it possible to compile binary statically linked with log4cxx
URL: https://github.com/apache/pulsar/pull/4519
 
 
   ### Motivation
   
   `LOG4CXX_USE_DYNAMIC_LIBS` has been added by https://github.com/apache/pulsar/pull/3503 as an option when building C++ client. However, log4cxx seems to be linked dynamically even if `LOG4CXX_USE_DYNAMIC_LIBS=OFF` is specified. This is because there is a mistake in `CMakeLists.txt`.
   
   ### Modifications
   
   Fixed the conditional branch in `CMakeLists.txt` as follows:
   ```
   if (LOG4CXX_USE_DYNAMIC_LIBS)
       ...
   endif (LOG4CXX_USE_DYNAMIC_LIBS)
       ...
   endif (LOG4CXX_USE_DYNAMIC_LIBS)
   ```
   ↓
   ```
   if (LOG4CXX_USE_DYNAMIC_LIBS)
       ...
   else ()
       ...
   endif (LOG4CXX_USE_DYNAMIC_LIBS)
   ```
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services