[GitHub] [incubator-iceberg] rdsr commented on issue #162: Upgrade Guava and don't use deprecated methods like Objects#ToStringHelper

[GitBox <gi...@apache.org>]

rdsr commented on issue #162: Upgrade Guava and don't use deprecated methods like Objects#ToStringHelper
URL: https://github.com/apache/incubator-iceberg/issues/162#issuecomment-491111349
 
 
   > My concern about upgrading the version we use is that it could cause problems downstream
   
   Could we shade our Guava dependency in our artifacts?  We'd have to make sure that guava is bundled in our artifacts and shaded and is not fetched transitively, whereas the rest of the dependencies can be fetched transitively.  Shadow plugins allows us to do this. This could be some work and could change how our artifacts are fetched . Users would have to rely on the different classifier or configuration for the artifacts for example.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org