You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/23 06:52:10 UTC
[GitHub] [skywalking] zhaoyuguang opened a new pull request #4106:
[test/plugin] immigrate test zookeeper scenario.
zhaoyuguang opened a new pull request #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve performance
- Related issues
https://github.com/apache/skywalking/issues/3583#issuecomment-567320256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] dmsolr commented on a change in pull request #4106:
[test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#discussion_r360786658
##########
File path: test/plugin/scenarios/redisson-scenario/support-version.list
##########
@@ -14,40 +14,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-3.11.5
-3.11.4
-3.11.3
-3.11.2
-3.11.1
-3.11.0
-3.10.7
-3.10.6
-3.10.5
-3.10.4
-3.10.3
-3.10.2
-3.10.1
-3.10.0
-3.9.1
-3.9.0
-3.8.2
-3.8.1
-3.8.0
-3.7.5
-3.7.4
-3.7.3
-3.7.2
-3.7.1
-3.7.0
-3.6.5
-3.6.4
-3.6.3
-3.6.2
-3.6.1
-3.6.0
-3.5.7
-3.5.6
-3.5.5
-3.5.4
-3.5.3
-3.5.2
\ No newline at end of file
+3.11.5
Review comment:
Is this a mistake? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4106:
[test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#issuecomment-568396562
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=h1) Report
> Merging [#4106](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7dc8065267b1ae6c4fba6fb1a6011e6990993096?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4106 +/- ##
==========================================
- Coverage 27.25% 27.18% -0.08%
==========================================
Files 1141 1141
Lines 25054 25054
Branches 3624 3624
==========================================
- Hits 6829 6810 -19
- Misses 17618 17642 +24
+ Partials 607 602 -5
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `31.46% <0%> (-13.49%)` | :arrow_down: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `73.77% <0%> (-3.28%)` | :arrow_down: |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `58.7% <0%> (+0.49%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=footer). Last update [7dc8065...923eadd](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4106:
[test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#issuecomment-568396562
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=h1) Report
> Merging [#4106](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7dc8065267b1ae6c4fba6fb1a6011e6990993096?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4106 +/- ##
==========================================
- Coverage 27.25% 27.23% -0.03%
==========================================
Files 1141 1141
Lines 25054 25054
Branches 3624 3624
==========================================
- Hits 6829 6823 -6
- Misses 17618 17625 +7
+ Partials 607 606 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=footer). Last update [7dc8065...f929b4f](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] zhaoyuguang commented on a change in pull request
#4106: [test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
zhaoyuguang commented on a change in pull request #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#discussion_r361043949
##########
File path: test/plugin/scenarios/zookeeper-scenario/src/main/java/org/apache/skywalking/apm/testcase/zookeeper/controller/ZookeeperController.java
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.testcase.zookeeper.controller;
+
+import org.apache.zookeeper.*;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.context.annotation.PropertySource;
+import org.springframework.stereotype.Controller;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.ResponseBody;
+
+@Controller
+@RequestMapping("/case")
+@PropertySource("classpath:application.properties")
+public class ZookeeperController {
+ private Logger logger = LoggerFactory.getLogger(ZookeeperController.class);
+
+ @Autowired
+ private ZooKeeper zooKeeper;
+
+ @RequestMapping("/zookeeper-case")
+ @ResponseBody
+ public String zookeeperCase() throws KeeperException, InterruptedException {
+ zooKeeper.create("/path", "data".getBytes(), ZooDefs.Ids.OPEN_ACL_UNSAFE, CreateMode.EPHEMERAL);
+ zooKeeper.exists("/path", watcher);
+ zooKeeper.delete("/path", -1);
+ return "Success";
+ }
+
+ @RequestMapping("/healthCheck")
+ @ResponseBody
+ public String healthCheck() {
+ try {
+ zooKeeper.delete("/path", -1);
+ } catch (Exception e) {
+ }
Review comment:
Right, I had fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] dmsolr commented on a change in pull request #4106:
[test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#discussion_r360786445
##########
File path: test/plugin/scenarios/gateway-scenario/configuration.yml
##########
@@ -18,6 +18,6 @@ type: jvm
entryService: http://localhost:8080/provider/b/testcase
healthCheck: http://localhost:8080/provider/b/healthCheck
startScript: ./bin/startup.sh
-framework: spring-cloud-gateway
Review comment:
You push the expected file, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4106:
[test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#issuecomment-568396562
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=h1) Report
> Merging [#4106](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4ed21e1c9dca59b8a4125c9769e7519af328414a?src=pr&el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4106 +/- ##
=========================================
- Coverage 27.31% 27.21% -0.1%
=========================================
Files 1140 1140
Lines 25027 25027
Branches 3619 3619
=========================================
- Hits 6835 6812 -23
- Misses 17587 17612 +25
+ Partials 605 603 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `31.46% <0%> (-15.74%)` | :arrow_down: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `73.77% <0%> (-3.28%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `60.36% <0%> (-0.91%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=footer). Last update [4ed21e1...21bc412](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4106:
[test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#issuecomment-568396562
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=h1) Report
> Merging [#4106](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4ed21e1c9dca59b8a4125c9769e7519af328414a?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4106 +/- ##
=========================================
- Coverage 27.31% 27.3% -0.01%
=========================================
Files 1140 1140
Lines 25027 25027
Branches 3619 3619
=========================================
- Hits 6835 6834 -1
Misses 17587 17587
- Partials 605 606 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `44.94% <0%> (-2.25%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `60.36% <0%> (-0.91%)` | :arrow_down: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `80.32% <0%> (+3.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=footer). Last update [4ed21e1...50c74f8](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] dmsolr commented on a change in pull request #4106:
[test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#discussion_r360785697
##########
File path: test/plugin/scenarios/zookeeper-scenario/config/expectedData.yaml
##########
@@ -0,0 +1,133 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+registryItems:
+ applications:
+ - {zookeeper-scenario: 2}
+ instances:
+ - {zookeeper-scenario: 1}
+ operationNames:
+ - zookeeper-scenario: [Zookeeper/WatchedEvent/NodeDeleted, /zookeeper-scenario/case/zookeeper-case,
+ Zookeeper/WatchedEvent/None, /zookeeper-scenario/case/healthCheck]
Review comment:
Why I cannot find the `Zookeeper/WatchedEvent/None` Segment in `SegmentItems`?
Am I missing things?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] zhaoyuguang commented on a change in pull request
#4106: [test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
zhaoyuguang commented on a change in pull request #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#discussion_r361043824
##########
File path: test/plugin/scenarios/zookeeper-scenario/src/main/resources/log4j2.xml
##########
@@ -0,0 +1,30 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ ~
+ -->
+<Configuration status="debug">
+<Appenders>
+ <Console name="Console" target="SYSTEM_OUT">
+ <PatternLayout pattern="%d [%traceId] %-5p %c{1}:%L - %m%n"/>
+ </Console>
+</Appenders>
+<Loggers>
+ <Root level="OFF">
+ <AppenderRef ref="Console"/>
+ </Root>
+</Loggers>
+</Configuration>
Review comment:
Like this?
```xml
<Configuration status="WARN">
<Appenders>
<Console name="Console" target="SYSTEM_ERR">
<PatternLayout charset="UTF-8" pattern="[%d{yyyy-MM-dd HH:mm:ss:SSS}] [%p] - %l - %m%n"/>
</Console>
</Appenders>
<Loggers>
<Root level="WARN">
<AppenderRef ref="Console"/>
</Root>
</Loggers>
</Configuration>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4106:
[test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#issuecomment-568396562
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=h1) Report
> Merging [#4106](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7dc8065267b1ae6c4fba6fb1a6011e6990993096?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4106 +/- ##
==========================================
- Coverage 27.25% 27.23% -0.03%
==========================================
Files 1141 1141
Lines 25054 25054
Branches 3624 3624
==========================================
- Hits 6829 6823 -6
- Misses 17618 17625 +7
+ Partials 607 606 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=footer). Last update [7dc8065...97b5228](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] dmsolr commented on a change in pull request #4106:
[test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#discussion_r360787042
##########
File path: test/plugin/scenarios/zookeeper-scenario/support-version.list
##########
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+3.5.6
+3.4.14
+3.4.9
+3.4.6
+3.4.3
+3.4.0
Review comment:
These are 6 versions, not 8 versions. please recheck the github-action configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] zhaoyuguang commented on a change in pull request
#4106: [test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
zhaoyuguang commented on a change in pull request #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#discussion_r360790515
##########
File path: test/plugin/scenarios/zookeeper-scenario/config/expectedData.yaml
##########
@@ -0,0 +1,133 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+registryItems:
+ applications:
+ - {zookeeper-scenario: 2}
+ instances:
+ - {zookeeper-scenario: 1}
+ operationNames:
+ - zookeeper-scenario: [Zookeeper/WatchedEvent/NodeDeleted, /zookeeper-scenario/case/zookeeper-case,
+ Zookeeper/WatchedEvent/None, /zookeeper-scenario/case/healthCheck]
Review comment:
At begin, when `healthCheck`
The delete method trigger `Zookeeper/WatchedEvent/None`,
So I do not assertion it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on a change in pull request #4106:
[test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#discussion_r360844704
##########
File path: test/plugin/scenarios/zookeeper-scenario/src/main/java/org/apache/skywalking/apm/testcase/zookeeper/controller/ZookeeperController.java
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.testcase.zookeeper.controller;
+
+import org.apache.zookeeper.*;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.context.annotation.PropertySource;
+import org.springframework.stereotype.Controller;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.ResponseBody;
+
+@Controller
+@RequestMapping("/case")
+@PropertySource("classpath:application.properties")
+public class ZookeeperController {
+ private Logger logger = LoggerFactory.getLogger(ZookeeperController.class);
+
+ @Autowired
+ private ZooKeeper zooKeeper;
+
+ @RequestMapping("/zookeeper-case")
+ @ResponseBody
+ public String zookeeperCase() throws KeeperException, InterruptedException {
+ zooKeeper.create("/path", "data".getBytes(), ZooDefs.Ids.OPEN_ACL_UNSAFE, CreateMode.EPHEMERAL);
+ zooKeeper.exists("/path", watcher);
+ zooKeeper.delete("/path", -1);
+ return "Success";
+ }
+
+ @RequestMapping("/healthCheck")
+ @ResponseBody
+ public String healthCheck() {
+ try {
+ zooKeeper.delete("/path", -1);
+ } catch (Exception e) {
+ }
Review comment:
Hi, exception should be throw, not ignored. right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] zhaoyuguang commented on a change in pull request
#4106: [test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
zhaoyuguang commented on a change in pull request #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#discussion_r360791405
##########
File path: test/plugin/scenarios/gateway-scenario/configuration.yml
##########
@@ -18,6 +18,6 @@ type: jvm
entryService: http://localhost:8080/provider/b/testcase
healthCheck: http://localhost:8080/provider/b/healthCheck
startScript: ./bin/startup.sh
-framework: spring-cloud-gateway
Review comment:
en. I fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4106: [test/plugin]
immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#issuecomment-568396562
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=h1) Report
> Merging [#4106](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4ed21e1c9dca59b8a4125c9769e7519af328414a?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4106 +/- ##
=========================================
- Coverage 27.31% 27.3% -0.01%
=========================================
Files 1140 1140
Lines 25027 25027
Branches 3619 3619
=========================================
- Hits 6835 6833 -2
- Misses 17587 17589 +2
Partials 605 605
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `44.94% <0%> (-2.25%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=footer). Last update [4ed21e1...21bc412](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4106:
[test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#issuecomment-568396562
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=h1) Report
> Merging [#4106](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7dc8065267b1ae6c4fba6fb1a6011e6990993096?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4106 +/- ##
=======================================
Coverage 27.26% 27.26%
=======================================
Files 1141 1141
Lines 25054 25054
Branches 3624 3624
=======================================
Hits 6830 6830
Misses 17618 17618
Partials 606 606
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=footer). Last update [7dc8065...f929b4f](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4106: [test/plugin]
immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4106:
[test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#issuecomment-568396562
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=h1) Report
> Merging [#4106](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/bf6491f4496a91cee6c10cdf15aa7f6054e57049?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4106 +/- ##
==========================================
+ Coverage 27.23% 27.26% +0.02%
==========================================
Files 1141 1141
Lines 25054 25054
Branches 3624 3624
==========================================
+ Hits 6823 6830 +7
+ Misses 17625 17618 -7
Partials 606 606
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `61.26% <0%> (+0.9%)` | :arrow_up: |
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `54.16% <0%> (+25%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=footer). Last update [bf6491f...72b2a41](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] zhaoyuguang commented on a change in pull request
#4106: [test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
zhaoyuguang commented on a change in pull request #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#discussion_r360791466
##########
File path: test/plugin/scenarios/zookeeper-scenario/support-version.list
##########
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+3.5.6
+3.4.14
+3.4.9
+3.4.6
+3.4.3
+3.4.0
Review comment:
I has fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4106:
[test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#issuecomment-568396562
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=h1) Report
> Merging [#4106](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ba192a9f1301e982211a1f5a0e13fe7f610810b7?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4106 +/- ##
==========================================
- Coverage 27.26% 27.18% -0.08%
==========================================
Files 1141 1141
Lines 25054 25054
Branches 3624 3624
==========================================
- Hits 6830 6811 -19
- Misses 17618 17640 +22
+ Partials 606 603 -3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `31.46% <0%> (-13.49%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `60.36% <0%> (-0.91%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=footer). Last update [ba192a9...969337d](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4106:
[test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#issuecomment-568396562
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=h1) Report
> Merging [#4106](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/923eadda894898f333f9bbdd2ee055a302a85c9a?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `54.54%`.
[](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4106 +/- ##
==========================================
+ Coverage 27.18% 27.23% +0.05%
==========================================
Files 1141 1141
Lines 25054 25057 +3
Branches 3624 3625 +1
==========================================
+ Hits 6810 6824 +14
+ Misses 17642 17627 -15
- Partials 602 606 +4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ver/core/query/ServiceInstanceTopologyBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvU2VydmljZUluc3RhbmNlVG9wb2xvZ3lCdWlsZGVyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...ing/oap/server/library/client/grpc/GRPCClient.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2dycGMvR1JQQ0NsaWVudC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `85.71% <0%> (-3.18%)` | :arrow_down: |
| [.../apm/agent/core/remote/StandardChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1N0YW5kYXJkQ2hhbm5lbEJ1aWxkZXIuamF2YQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `94.23% <100%> (+0.11%)` | :arrow_up: |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `58.2% <0%> (-0.5%)` | :arrow_down: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `77.04% <0%> (+3.27%)` | :arrow_up: |
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4106/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `44.94% <0%> (+13.48%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=footer). Last update [923eadd...5f4f3ca](https://codecov.io/gh/apache/skywalking/pull/4106?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] dmsolr commented on a change in pull request #4106:
[test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#discussion_r360925616
##########
File path: test/plugin/scenarios/zookeeper-scenario/src/main/resources/log4j2.xml
##########
@@ -0,0 +1,30 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ ~
+ -->
+<Configuration status="debug">
+<Appenders>
+ <Console name="Console" target="SYSTEM_OUT">
+ <PatternLayout pattern="%d [%traceId] %-5p %c{1}:%L - %m%n"/>
+ </Console>
+</Appenders>
+<Loggers>
+ <Root level="OFF">
+ <AppenderRef ref="Console"/>
+ </Root>
+</Loggers>
+</Configuration>
Review comment:
Note that, we will discard the `systemout` logs. If it is expected print, I suggest using the new log-configuration template.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] zhaoyuguang commented on a change in pull request
#4106: [test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
zhaoyuguang commented on a change in pull request #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#discussion_r360791424
##########
File path: test/plugin/scenarios/redisson-scenario/support-version.list
##########
@@ -14,40 +14,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-3.11.5
-3.11.4
-3.11.3
-3.11.2
-3.11.1
-3.11.0
-3.10.7
-3.10.6
-3.10.5
-3.10.4
-3.10.3
-3.10.2
-3.10.1
-3.10.0
-3.9.1
-3.9.0
-3.8.2
-3.8.1
-3.8.0
-3.7.5
-3.7.4
-3.7.3
-3.7.2
-3.7.1
-3.7.0
-3.6.5
-3.6.4
-3.6.3
-3.6.2
-3.6.1
-3.6.0
-3.5.7
-3.5.6
-3.5.5
-3.5.4
-3.5.3
-3.5.2
\ No newline at end of file
+3.11.5
Review comment:
en. I fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] zhaoyuguang commented on a change in pull request
#4106: [test/plugin] immigrate test zookeeper scenario.
Posted by GitBox <gi...@apache.org>.
zhaoyuguang commented on a change in pull request #4106: [test/plugin] immigrate test zookeeper scenario.
URL: https://github.com/apache/skywalking/pull/4106#discussion_r361273464
##########
File path: test/plugin/scenarios/zookeeper-scenario/config/expectedData.yaml
##########
@@ -0,0 +1,133 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+registryItems:
+ applications:
+ - {zookeeper-scenario: 2}
+ instances:
+ - {zookeeper-scenario: 1}
+ operationNames:
+ - zookeeper-scenario: [Zookeeper/WatchedEvent/NodeDeleted, /zookeeper-scenario/case/zookeeper-case,
+ Zookeeper/WatchedEvent/None, /zookeeper-scenario/case/healthCheck]
Review comment:
I had remove this unuse SegmentItem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services