[GitHub] agrawaldevesh opened a new pull request #6718: Fix uniqueness constraints on tables table

[GitBox <gi...@apache.org>]

agrawaldevesh opened a new pull request #6718: Fix uniqueness constraints on tables table
URL: https://github.com/apache/incubator-superset/pull/6718
 
 
   Summary: The tables table was inconsistent wrt to the schema resulting
   from the migrations and the model schema. The migrations said there was
   uniqueness constraint on table_name, but the model schema said there
   should be one on (database_id, table_name)
   
   I hit this bug when trying to add the same table via two different
   databases in the UI. It refused me and it wasn't immediately apparent
   what was the cause (since the code referred to the uniquenes
   constraint). After a bunch of debugging I narrowed down to this
   "missing" migration script: That migrates from the uniq(table_name) to
   uniq(database_id, schema, table_name) and fixes both the model and
   migration script
   
   And as an aside, also adds ctags file to .gitignore

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org