[GitHub] [kafka] OmniaGM commented on a change in pull request #11008: Kafka-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

[GitBox <gi...@apache.org>]

OmniaGM commented on a change in pull request #11008:
URL: https://github.com/apache/kafka/pull/11008#discussion_r667511546



##########
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##########
@@ -315,11 +321,14 @@ object ConsoleConsumer extends Logging {
 
     formatter.configure(formatterArgs.asScala.asJava)
 
-    val topicOrFilterOpt = List(topicOpt, whitelistOpt).filter(options.has)
+    val topicOrFilterOpt = List(topicOpt, whitelistOpt, includeOpt).filter(options.has)
     if (topicOrFilterOpt.size != 1)
-      CommandLineUtils.printUsageAndDie(parser, "Exactly one of whitelist/topic is required.")
+      CommandLineUtils.printUsageAndDie(parser, "Exactly one of include/topic is required.")

Review comment:
       We can have `include/whitelist/topic` and remove it when we completely remove `--whitelist` later. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org