You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/01/03 10:49:07 UTC

[GitHub] anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs
URL: https://github.com/apache/zookeeper/pull/742#discussion_r244963490
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/EphemeralType.java
 ##########
 @@ -212,7 +212,8 @@ public static void validateServerId(long serverId) {
      */
     public static void validateTTL(CreateMode mode, long ttl) {
         if (mode.isTTL()) {
-            TTL.toEphemeralOwner(ttl);
+            // nothing to do in 3.5 was:
+            // TTL.toEphemeralOwner(ttl);
 
 Review comment:
   @eolivelli How is this code change related to this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services