[jira] Commented: (FTPSERVER-357) Implement IP Filtering based on black or white list

["Niklas Gustavsson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847084#action_12847084 ] 

Niklas Gustavsson commented on FTPSERVER-357:
---------------------------------------------

Some comments on the patch:
* We need to do this change without removing method in the public API, otherwise it needs to wait until a future 2.0. Would be good if we can get it into 1.1
* Patch includes lots of changes to AbstractListener, is that part of this change (perhaps only whitespace changes)?
* Patch includes changes to NativeFileSystemView which does not belong in this patch 
* //TODO what's the good exception to throw from here?  -> FtpServerConfigurationException
* Would it be a good idea to make DefaultIpFilter immutable?

> Implement IP Filtering based on black or white list
> ---------------------------------------------------
>
>                 Key: FTPSERVER-357
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-357
>             Project: FtpServer
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Sai Pullabhotla
>             Fix For: 1.1.0
>
>         Attachments: ftpserver-ipfilter.patch
>
>
> Create a new IP Filter based on black or white list to deny or allow incoming client connections. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.