You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2013/12/05 17:19:01 UTC
Review Request 16040: missing synchronization in access to leaderCache in
KafkaApis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16040/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1169
https://issues.apache.org/jira/browse/KAFKA-1169
Repository: kafka
Description
-------
kafka-1169
Diffs
-----
core/src/main/scala/kafka/server/KafkaApis.scala c9f92a285ce3e8513461304570a6ece205ab03ef
Diff: https://reviews.apache.org/r/16040/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 16040: missing synchronization in access to leaderCache
in KafkaApis
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16040/#review29817
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On Dec. 5, 2013, 4:18 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16040/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2013, 4:18 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1169
> https://issues.apache.org/jira/browse/KAFKA-1169
>
>
> Repository: kafka
>
>
> Description
> -------
>
> kafka-1169
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/KafkaApis.scala c9f92a285ce3e8513461304570a6ece205ab03ef
>
> Diff: https://reviews.apache.org/r/16040/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 16040: missing synchronization in access to leaderCache
in KafkaApis
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16040/#review29820
-----------------------------------------------------------
Why we need synchronization here for reading the cache?
- Guozhang Wang
On Dec. 5, 2013, 4:18 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16040/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2013, 4:18 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1169
> https://issues.apache.org/jira/browse/KAFKA-1169
>
>
> Repository: kafka
>
>
> Description
> -------
>
> kafka-1169
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/KafkaApis.scala c9f92a285ce3e8513461304570a6ece205ab03ef
>
> Diff: https://reviews.apache.org/r/16040/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>