Re: [PR] [SPARK-47445][CONNECT] Add new ExplainMode - SilentMode [spark]

["robreeves (via GitHub)" <gi...@apache.org>]

robreeves commented on code in PR #45542:
URL: https://github.com/apache/spark/pull/45542#discussion_r1529263325


##########
connector/connect/common/src/main/protobuf/spark/connect/base.proto:
##########
@@ -125,6 +125,9 @@ message AnalyzePlanRequest {
 
       // Generates a physical plan outline and also node details.
       EXPLAIN_MODE_FORMATTED = 5;
+
+      // Does not generate any plan when used.
+      EXPLAIN_MODE_SILENT = 6;

Review Comment:
   nit: Disabled feels more intuitive to me than silent for the naming.
   ```suggestion
         EXPLAIN_MODE_DISABLED = 6;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org