[jira] [Closed] (WAGON-495) Fix checkoutDirectory leak

["Michael Osipov (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WAGON-495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Osipov closed WAGON-495.
--------------------------------
    Resolution: Fixed

Fixed with [2e70c858b7031b105951ee33252410590ae5e785|https://gitbox.apache.org/repos/asf?p=maven-wagon.git&a=commit&h=2e70c858b7031b105951ee33252410590ae5e785].

> Fix checkoutDirectory leak
> --------------------------
>
>                 Key: WAGON-495
>                 URL: https://issues.apache.org/jira/browse/WAGON-495
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-scm
>    Affects Versions: 3.0.0, 3.1.0
>            Reporter: Ilya Basin
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 3.1.0
>
>
> During deploy artifacts to SVN an instance of ScmWagon is initialized and artifact metadata is downloaded to a local folder. After that maven tries to upload the jar file. ScmWagon.put(File,String) is called which internally overwrites the checkoutDirectory field and checks out the repo again to another temporary folder. The original folder is forgotten.
> Maven uploads jars, poms, checksums and for each file ScmWagon checks out a new directory.
> In the end the closeConnection() method is called which removes the last used folder.
> UPD: this causes false positive in testWagonPutDirectoryWhenDirectoryAlreadyExists(): the test deletes the test checkout dir before calling get(), but the wagon checkout dir remains and the file is retrieved from there.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)