[GitHub] danielcweeks commented on a change in pull request #30: Update to Spark 2.4

[GitBox <gi...@apache.org>]

danielcweeks commented on a change in pull request #30: Update to Spark 2.4
URL: https://github.com/apache/incubator-iceberg/pull/30#discussion_r240302343
 
 

 ##########
 File path: build.gradle
 ##########
 @@ -302,7 +300,7 @@ project(':iceberg-presto-runtime') {
         shadow "org.apache.avro:avro:$avroVersion"
         shadow ("org.apache.hive:hive-standalone-metastore:$hiveVersion") {
             exclude group: 'org.apache.hadoop', module: 'hadoop-common'
-            exclude group: 'org.apache.orc', module: 'orc-core'
+//            exclude group: 'org.apache.orc', module: 'orc-core'
 
 Review comment:
   @dongjoon-hyun We'd really appreciate some support getting ORC back in.  The current implementation is incomplete and rather than provide inconsistent behavior, it's probably best to remove until the implementation is complete. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services