You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/07/09 05:53:50 UTC
[GitHub] [netbeans] mbien commented on a diff in pull request #4353: Improvements to JDK download and registration UI.
mbien commented on code in PR #4353:
URL: https://github.com/apache/netbeans/pull/4353#discussion_r917224336
##########
java/java.disco/src/org/netbeans/modules/java/disco/AdvancedPanel.java:
##########
@@ -378,12 +395,12 @@ private void eaCheckBoxActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FI
}//GEN-LAST:event_eaCheckBoxActionPerformed
private void filterChanged() {
- updateData( (Distribution) distributionComboBox.getSelectedItem(),
- (Integer) versionComboBox.getSelectedItem(),
- (Architecture) architectureComboBox.getSelectedItem(),
- latestCheckBox.isSelected() ? Latest.OVERALL : Latest.ALL_OF_VERSION,
- (PackageType) packageTypeComboBox.getSelectedItem(),
- eaCheckBox.isSelected());
+ updateData((Distribution) distributionComboBox.getSelectedItem(),
+ (Integer) versionComboBox.getSelectedItem(),
+ (Architecture) architectureComboBox.getSelectedItem(),
+ latestCheckBox.isSelected() ? Latest.OVERALL : Latest.ALL_OF_VERSION,
+ (PackageType) packageTypeComboBox.getSelectedItem(),
+ eaCheckBox.isSelected());
Review Comment:
since there are only whitespace changes here, I was wondering if you wanted to call the utility getters you made from here but you forgot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists