[GitHub] [arrow-rs] thinkharderdev commented on a diff in pull request #2656: Fix flaky test `test_fuzz_async_reader_selection`

[GitBox <gi...@apache.org>]

thinkharderdev commented on code in PR #2656:
URL: https://github.com/apache/arrow-rs/pull/2656#discussion_r963571815


##########
parquet/src/arrow/async_reader.rs:
##########
@@ -1015,7 +1014,7 @@ mod tests {
             let mut selectors = vec![];
 
             while total_rows < 7300 {
-                let row_count: usize = rand.gen_range(0..100);
+                let row_count: usize = rand.gen_range(1..100);

Review Comment:
   It can if you manually construct one as we do in this test but in practice it would be non-sensical (and you wouldn't ever get one if you built a `RowSelection` from ranges or `BooleanArray`s). So depending on your perspective we could consider this a bug in the `ParquetRecordBatchReader` (probably, not sure where the actual issue comes up) but I think if we did the solution would be to just disallow row counts of 0 explicitly. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org