[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #16594: [Numpy] implement np.column_stack

[GitBox <gi...@apache.org>]

haojin2 commented on a change in pull request #16594: [Numpy] implement np.column_stack
URL: https://github.com/apache/incubator-mxnet/pull/16594#discussion_r338272300
 
 

 ##########
 File path: python/mxnet/ndarray/numpy/_op.py
 ##########
 @@ -38,8 +38,7 @@
            'std', 'var', 'indices', 'copysign', 'ravel', 'hanning', 'hamming', 'blackman', 'flip',
            'around', 'hypot', 'rad2deg', 'deg2rad', 'unique', 'lcm', 'tril', 'identity', 'take',
            'ldexp', 'vdot', 'inner', 'outer', 'equal', 'not_equal', 'greater', 'less', 'greater_equal', 'less_equal',
-           'hsplit', 'rot90', 'einsum', 'true_divide']
-
+           'hsplit', 'rot90', 'einsum', 'true_divide', 'column_stack']
 
 Review comment:
   Please move 'column_stack' to after `vstack` in this list.
   Also please move the function definition to after `vstack` as well in the file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services