You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2022/01/17 00:58:28 UTC
svn commit: r1897138 - in /poi/trunk: poi-scratchpad/src/main/java/org/apache/poi/hslf/record/ poi/src/main/java/org/apache/poi/poifs/filesystem/ poi/src/main/java/org/apache/poi/poifs/property/ poi/src/main/java/org/apache/poi/ss/util/cellwalk/
Author: fanningpj
Date: Mon Jan 17 00:58:27 2022
New Revision: 1897138
URL: http://svn.apache.org/viewvc?rev=1897138&view=rev
Log:
remove use of deprecated commons-math methods
Modified:
poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/record/MasterTextPropAtom.java
poi/trunk/poi/src/main/java/org/apache/poi/poifs/filesystem/POIFSFileSystem.java
poi/trunk/poi/src/main/java/org/apache/poi/poifs/property/RootProperty.java
poi/trunk/poi/src/main/java/org/apache/poi/ss/util/cellwalk/CellWalk.java
Modified: poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/record/MasterTextPropAtom.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/record/MasterTextPropAtom.java?rev=1897138&r1=1897137&r2=1897138&view=diff
==============================================================================
--- poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/record/MasterTextPropAtom.java (original)
+++ poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/record/MasterTextPropAtom.java Mon Jan 17 00:58:27 2022
@@ -26,7 +26,6 @@ import java.util.List;
import java.util.Map;
import java.util.function.Supplier;
-import org.apache.commons.math3.util.ArithmeticUtils;
import org.apache.poi.hslf.model.textproperties.IndentProp;
import org.apache.poi.util.GenericRecordUtil;
import org.apache.poi.util.IOUtils;
@@ -132,7 +131,7 @@ public final class MasterTextPropAtom ex
*/
private void write() {
int pos = 0;
- long newSize = ArithmeticUtils.mulAndCheck((long)indents.size(), (long)6);
+ long newSize = Math.multiplyExact((long)indents.size(), (long)6);
_data = IOUtils.safelyAllocate(newSize, MAX_RECORD_LENGTH);
for (IndentProp prop : indents) {
LittleEndian.putInt(_data, pos, prop.getCharactersCovered());
Modified: poi/trunk/poi/src/main/java/org/apache/poi/poifs/filesystem/POIFSFileSystem.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/poifs/filesystem/POIFSFileSystem.java?rev=1897138&r1=1897137&r2=1897138&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/poifs/filesystem/POIFSFileSystem.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/poifs/filesystem/POIFSFileSystem.java Mon Jan 17 00:58:27 2022
@@ -33,7 +33,6 @@ import java.util.Iterator;
import java.util.List;
import org.apache.commons.io.output.UnsynchronizedByteArrayOutputStream;
-import org.apache.commons.math3.util.ArithmeticUtils;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.apache.poi.EmptyFileException;
@@ -127,7 +126,7 @@ public class POIFSFileSystem extends Blo
protected void createNewDataSource() {
// Data needs to initially hold just the header block,
// a single bat block, and an empty properties section
- long blockSize = ArithmeticUtils.mulAndCheck(bigBlockSize.getBigBlockSize(), 3L);
+ long blockSize = Math.multiplyExact(bigBlockSize.getBigBlockSize(), 3L);
_data = new ByteArrayBackedDataSource(IOUtils.safelyAllocate(blockSize, MAX_RECORD_LENGTH));
}
@@ -455,7 +454,7 @@ public class POIFSFileSystem extends Blo
// Ensure there's a spot in the file for it
ByteBuffer buffer = ByteBuffer.allocate(bigBlockSize.getBigBlockSize());
// Header isn't in BATs
- long writeTo = ArithmeticUtils.mulAndCheck(1L + offset, bigBlockSize.getBigBlockSize());
+ long writeTo = Math.multiplyExact(1L + offset, (long)bigBlockSize.getBigBlockSize());
_data.write(buffer, writeTo);
// All done
return newBAT;
Modified: poi/trunk/poi/src/main/java/org/apache/poi/poifs/property/RootProperty.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/poifs/property/RootProperty.java?rev=1897138&r1=1897137&r2=1897138&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/poifs/property/RootProperty.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/poifs/property/RootProperty.java Mon Jan 17 00:58:27 2022
@@ -17,7 +17,6 @@
package org.apache.poi.poifs.property;
-import org.apache.commons.math3.util.ArithmeticUtils;
import org.apache.poi.poifs.common.POIFSConstants;
/**
@@ -56,7 +55,7 @@ public final class RootProperty extends
{
final int BLOCK_SHIFT = 6;
final int _block_size = 1 << BLOCK_SHIFT;
- super.setSize(ArithmeticUtils.mulAndCheck(size, _block_size));
+ super.setSize(Math.multiplyExact(size, _block_size));
}
/**
Modified: poi/trunk/poi/src/main/java/org/apache/poi/ss/util/cellwalk/CellWalk.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/util/cellwalk/CellWalk.java?rev=1897138&r1=1897137&r2=1897138&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/util/cellwalk/CellWalk.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/util/cellwalk/CellWalk.java Mon Jan 17 00:58:27 2022
@@ -17,10 +17,6 @@
package org.apache.poi.ss.util.cellwalk;
-import static org.apache.commons.math3.util.ArithmeticUtils.addAndCheck;
-import static org.apache.commons.math3.util.ArithmeticUtils.mulAndCheck;
-import static org.apache.commons.math3.util.ArithmeticUtils.subAndCheck;
-
import org.apache.poi.ss.usermodel.Cell;
import org.apache.poi.ss.usermodel.CellType;
import org.apache.poi.ss.usermodel.Row;
@@ -93,9 +89,9 @@ public class CellWalk {
continue;
}
- long rowSize = mulAndCheck(subAndCheck(ctx.rowNumber, firstRow), (long)width);
+ long rowSize = Math.multiplyExact(Math.subtractExact(ctx.rowNumber, firstRow), (long)width);
- ctx.ordinalNumber = addAndCheck(rowSize, (ctx.colNumber - firstColumn + 1));
+ ctx.ordinalNumber = Math.addExact(rowSize, (ctx.colNumber - firstColumn + 1));
handler.onCell(currentCell, ctx);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org