[GitHub] [fineract] b0c1 commented on a diff in pull request #3269: FINERACT-1926: Fineract Asset Externalization - Cancel

["b0c1 (via GitHub)" <gi...@apache.org>]

b0c1 commented on code in PR #3269:
URL: https://github.com/apache/fineract/pull/3269#discussion_r1238659489


##########
fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersReadServiceImpl.java:
##########
@@ -120,6 +120,13 @@ public ExternalTransferData retrieveFirstTransferByExternalId(ExternalId externa
                 .orElseThrow(() -> new ExternalAssetOwnerTransferNotFoundException(externalTransferId));
     }
 
+    @Override
+    public Long retrieveFirstTransferIdByExternalId(ExternalId externalTransferId) {
+        return externalAssetOwnerTransferRepository.findFirstByExternalIdOrderByIdAsc(externalTransferId)

Review Comment:
   I think it's irrelevant because transferExternal id will identify only one transfer (or two if already cancelled), but Ofc we can get the latest...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org