You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by bi...@apache.org on 2014/12/20 02:50:00 UTC
[1/2] git commit: [flex-sdk] [refs/heads/release4.14.0] - Now,
if any ancestor chain of BusyIndicator becomes visible,
it will start spinning. Fixes bug
https://issues.apache.org/jira/browse/FLEX-34701
Repository: flex-sdk
Updated Branches:
refs/heads/release4.14.0 2f5c5a467 -> 546f61abc
Now, if any ancestor chain of BusyIndicator becomes visible, it will start spinning.
Fixes bug https://issues.apache.org/jira/browse/FLEX-34701
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/b30d7e85
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/b30d7e85
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/b30d7e85
Branch: refs/heads/release4.14.0
Commit: b30d7e8543f1493773e7aa6737285c300d3cbd68
Parents: 2f5c5a4
Author: OmPrakash Muppirala <bi...@gmail.com>
Authored: Fri Dec 19 17:40:01 2014 -0800
Committer: OmPrakash Muppirala <bi...@gmail.com>
Committed: Fri Dec 19 17:48:10 2014 -0800
----------------------------------------------------------------------
.../spark/src/spark/components/BusyIndicator.as | 54 +++++++++++++++++++-
1 file changed, 52 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/b30d7e85/frameworks/projects/spark/src/spark/components/BusyIndicator.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/spark/src/spark/components/BusyIndicator.as b/frameworks/projects/spark/src/spark/components/BusyIndicator.as
index 1f665ee..259393d 100644
--- a/frameworks/projects/spark/src/spark/components/BusyIndicator.as
+++ b/frameworks/projects/spark/src/spark/components/BusyIndicator.as
@@ -24,6 +24,7 @@ package spark.components
import mx.core.IUIComponent;
import mx.core.IVisualElement;
import mx.events.FlexEvent;
+ import mx.events.PropertyChangeEvent;
import mx.states.State;
import spark.components.supportClasses.SkinnableComponent;
@@ -146,10 +147,48 @@ package spark.components
];
}
+ override protected function commitProperties():void
+ {
+ if (effectiveVisibilityChanged)
+ {
+ // if visibility changed, re-compute them here
+ computeEffectiveVisibility();
+
+ if (canRotate())
+ {
+ currentState = "rotatingState";
+ }
+ else
+ {
+ currentState = "notRotatingState";
+ }
+
+ invalidateSkinState();
+ effectiveVisibilityChanged = false;
+ }
+ super.commitProperties();
+ }
+
override protected function getCurrentSkinState():String
{
return currentState;
- }
+ }
+
+ /**
+ * @private
+ * Override so we know when visibility is set. The initialized
+ * property calls setVisible() with noEvent == true
+ * so we wouldn't get a visibility event if we just listened
+ * for events.
+ */
+ override public function setVisible(value:Boolean,
+ noEvent:Boolean = false):void
+ {
+ super.setVisible(value, noEvent);
+
+ effectiveVisibilityChanged = true;
+ invalidateProperties();
+ }
private function addedToStageHandler(event:Event):void
{
@@ -160,8 +199,8 @@ package spark.components
if (canRotate())
currentState = "rotatingState";
- addVisibilityListeners();
invalidateSkinState();
+ addVisibilityListeners();
}
private function removedFromStageHandler(event:Event):void
@@ -274,6 +313,17 @@ package spark.components
invalidateProperties();
}
+ override protected function layer_PropertyChange(event:PropertyChangeEvent):void
+ {
+ super.layer_PropertyChange(event);
+
+ if (event.property == "effectiveVisibility")
+ {
+ effectiveVisibilityChanged = true;
+ invalidateProperties();
+ }
+ }
+
}
}
[2/2] git commit: [flex-sdk] [refs/heads/release4.14.0] - Add latest
bug fix
Posted by bi...@apache.org.
Add latest bug fix
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/546f61ab
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/546f61ab
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/546f61ab
Branch: refs/heads/release4.14.0
Commit: 546f61abcfb66fe617ad65ca6f3cd20ae7a85c01
Parents: b30d7e8
Author: OmPrakash Muppirala <bi...@gmail.com>
Authored: Fri Dec 19 17:46:24 2014 -0800
Committer: OmPrakash Muppirala <bi...@gmail.com>
Committed: Fri Dec 19 17:48:33 2014 -0800
----------------------------------------------------------------------
RELEASE_NOTES | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/546f61ab/RELEASE_NOTES
----------------------------------------------------------------------
diff --git a/RELEASE_NOTES b/RELEASE_NOTES
index 7ac671f..b7fdc57 100644
--- a/RELEASE_NOTES
+++ b/RELEASE_NOTES
@@ -18,6 +18,7 @@ AIR and Flash Player Support
Bug Fixes
---------
+FLEX-34701 BusyIndicator does not spin when its container becomes visible
FLEX-34694 Flatspark: Setting Applications "chromeColor" style throws error
FLEX-34693 Flatspark ButtonIcon: Introduce property 'iconFontSize' to set icon
size directly