You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2012/09/26 00:30:17 UTC

Review Request: Short term fix for fire-walling some potent messages from the incorrect master

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7270/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Description
-------

See summary


This addresses bug MESOS-284.
    https://issues.apache.org/jira/browse/MESOS-284


Diffs
-----

  src/sched/sched.cpp 53e26d3f202f29eb864403ff35dd48891bb0b6be 
  src/slave/slave.cpp 49d8e761ca9a8af4a910aea736b5ee0288fd67b2 

Diff: https://reviews.apache.org/r/7270/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request: Short term fix for fire-walling some potent messages from the incorrect master

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7270/#review11917
-----------------------------------------------------------

Ship it!


Talked with vinod a bit about the window case where a slave goes master-less (and then the master's shutdown message arrives), it seems fine to drop the message in that case and have the slave reconnect when it can.

- Ben Mahler


On Sept. 25, 2012, 10:30 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7270/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2012, 10:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> This addresses bug MESOS-284.
>     https://issues.apache.org/jira/browse/MESOS-284
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp 53e26d3f202f29eb864403ff35dd48891bb0b6be 
>   src/slave/slave.cpp 49d8e761ca9a8af4a910aea736b5ee0288fd67b2 
> 
> Diff: https://reviews.apache.org/r/7270/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>