You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "mfordjody (via GitHub)" <gi...@apache.org> on 2026/08/04 15:52:43 UTC

[PR] Fixed grpc inbound potential issues [dubbo-kubernetes]

mfordjody opened a new pull request, #987:
URL: https://github.com/apache/dubbo-kubernetes/pull/987

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Fixed grpc inbound potential issues [dubbo-kubernetes]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] merged PR #987:
URL: https://github.com/apache/dubbo-kubernetes/pull/987


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Fixed grpc inbound potential issues [dubbo-kubernetes]

Posted by "mfordjody (via GitHub)" <gi...@apache.org>.
mfordjody commented on PR #987:
URL: https://github.com/apache/dubbo-kubernetes/pull/987#issuecomment-5181549408

   /lgtm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Fixed grpc inbound potential issues [dubbo-kubernetes]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #987:
URL: https://github.com/apache/dubbo-kubernetes/pull/987#issuecomment-5181554181

   `/lgtm` recorded by @mfordjody. GitHub Auto-merge will squash merge the PR after required CI passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Fixed grpc inbound potential issues [dubbo-kubernetes]

Posted by "mfordjody (via GitHub)" <gi...@apache.org>.
mfordjody commented on PR #987:
URL: https://github.com/apache/dubbo-kubernetes/pull/987#issuecomment-5202829217

   /lgtm
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Fixed grpc inbound potential issues [dubbo-kubernetes]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #987:
URL: https://github.com/apache/dubbo-kubernetes/pull/987#issuecomment-5202830041

   ## [Codecov](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/987?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `65.66265%` with `57 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 19.63%. Comparing base ([`6c3e8a4`](https://app.codecov.io/gh/apache/dubbo-kubernetes/commit/6c3e8a446547f204920fc7c11b7a6f2ab4e4ec61?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`76fa6f1`](https://app.codecov.io/gh/apache/dubbo-kubernetes/commit/76fa6f18ebef9c9463074d76a74886f850994be2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/987?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [dubbod/discovery/cmd/app/grpc\_inbound.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/987?src=pr&el=tree&filepath=dubbod%2Fdiscovery%2Fcmd%2Fapp%2Fgrpc_inbound.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZHViYm9kL2Rpc2NvdmVyeS9jbWQvYXBwL2dycGNfaW5ib3VuZC5nbw==) | 65.66% | [51 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/987?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #987      +/-   ##
   ==========================================
   + Coverage   18.38%   19.63%   +1.25%     
   ==========================================
     Files         352      351       -1     
     Lines       34029    34354     +325     
   ==========================================
   + Hits         6255     6747     +492     
   + Misses      27030    26826     -204     
   - Partials      744      781      +37     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/987/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [unittests](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `19.63% <65.66%> (+1.25%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/987?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Fixed grpc inbound potential issues [dubbo-kubernetes]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #987:
URL: https://github.com/apache/dubbo-kubernetes/pull/987#issuecomment-5202832497

   Merged on behalf of @mfordjody via `/lgtm`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org