You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "jfrag1 (via GitHub)" <gi...@apache.org> on 2023/04/17 19:03:03 UTC

[GitHub] [superset] jfrag1 commented on a diff in pull request #23714: chore(api v1): Deprecate superset/override_role_permissions endpoint

jfrag1 commented on code in PR #23714:
URL: https://github.com/apache/superset/pull/23714#discussion_r1169165132


##########
superset/security/manager.py:
##########
@@ -207,7 +207,6 @@ class SupersetSecurityManager(  # pylint: disable=too-many-public-methods
     }
 
     ADMIN_ONLY_PERMISSIONS = {
-        "can_override_role_permissions",

Review Comment:
   Only removing since I noticed it was duplicated a couple lines below



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org