You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "advancedxy (via GitHub)" <gi...@apache.org> on 2023/03/05 12:24:33 UTC

[GitHub] [incubator-uniffle] advancedxy commented on pull request #637: [#615] improvement: Reduce task binary by removing 'partitionToServers' from RssShuffleHandle

advancedxy commented on PR #637:
URL: https://github.com/apache/incubator-uniffle/pull/637#issuecomment-1455076963

   > @advancedxy @xianjingfeng Do you have another suggestion?
   
   I'm not sure, this pr introduced some quite complex logic to broadcast shuffle handle info. 
   
   If I was implementing this feature, I would just use Kryo by default, and in RSSShuffleManager indicating users to either 
   turn off `spark.kryo.registerRequired` (which is explicitly set by user) or manually register RssShuffleHandle.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org