You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "Imvedansh (via GitHub)" <gi...@apache.org> on 2025/03/20 12:59:28 UTC

[PR] In Install.md->CloudStack UI Commands(npm) [cloudstack]

Imvedansh opened a new pull request, #10593:
URL: https://github.com/apache/cloudstack/pull/10593

   Description
   
   This PR updates INSTALL.md to include essential setup commands for first-time contributors, ensuring a smoother installation process and reducing setup errors.
   Changes:
   
       Added mysql_secure_installation to improve MySQL security.
       Included steps for setting up the CloudStack UI (npm install, npm build, npm start).
       Clarified the requirement to set CS_URL=http://localhost:8080/client in .env.local for API communication.
       Explicitly mentioned that the management server runs at http://localhost:5050/.
   
   These improvements will make onboarding easier and reduce setup issues.
   #10590 
   Types of changes
   
   Breaking change (fix or feature that would cause existing functionality to change)
   New feature (non-breaking change which adds functionality)
   Bug fix (non-breaking change which fixes an issue)
   Enhancement (improves an existing feature and functionality)
   Cleanup (Code refactoring and cleanup, that may add test cases)
   build/CI
   
       test (unit or integration test code)
   
   Feature/Enhancement Scale or Bug Severity
   Feature/Enhancement Scale
   
   Minor
   
       Major
   
   Bug Severity
   
   BLOCKER
   Critical
   Major
   Minor
   
       Trivial
   
   Screenshots :
   
   ![Screenshot from 2025-03-20 18-22-45](https://github.com/user-attachments/assets/8c7b6056-9b3b-4375-b6b7-aa0048599fd8)
   
   
   
   How Has This Been Tested?
   
       Followed the updated steps on a fresh Ubuntu 22.04.5 environment.
       Ensured the UI builds successfully and connects to the management server.
       Verified mysql_secure_installation improves security settings.
       Confirmed the management server is accessible at http://localhost:5050/.
   
   How did you try to break this feature and the system with this change?
   
       Tested installation without mysql_secure_installation to confirm the security risk.
       Omitted CS_URL in .env.local and verified API connection failure.
       Attempted to start the UI without installing dependencies to confirm issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] In Install.md->CloudStack UI Commands(npm) [cloudstack]

Posted by "Imvedansh (via GitHub)" <gi...@apache.org>.
Imvedansh commented on PR #10593:
URL: https://github.com/apache/cloudstack/pull/10593#issuecomment-2749175032

   @Pearl1594 @DaanHoogland 
   I agree, Thank you for noticing
   Made the changes as well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] In Install.md->CloudStack UI Commands(npm) [cloudstack]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #10593:
URL: https://github.com/apache/cloudstack/pull/10593#issuecomment-2750787117

   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] In Install.md->CloudStack UI Commands(npm) [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #10593: In Install.md->CloudStack UI Commands(npm)
URL: https://github.com/apache/cloudstack/pull/10593


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] In Install.md->CloudStack UI Commands(npm) [cloudstack]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #10593:
URL: https://github.com/apache/cloudstack/pull/10593#issuecomment-2740377163

   Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
   Here are some useful points:
   - In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
   - Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
   - Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
   - Please follow [ASF Code of Conduct](https://github.com/apache/.github/blob/main/.github/CODE_OF_CONDUCT.md) for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
   - Be sure to read the [CloudStack Coding Conventions](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions).
   Apache CloudStack is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
   Slack: https://apachecloudstack.slack.com/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] In Install.md->CloudStack UI Commands(npm) [cloudstack]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #10593:
URL: https://github.com/apache/cloudstack/pull/10593#issuecomment-2747551030

   ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10593?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 3.99%. Comparing base [(`9dceae4`)](https://app.codecov.io/gh/apache/cloudstack/commit/9dceae46148f916f4094f90797567652667ccadb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`354c903`)](https://app.codecov.io/gh/apache/cloudstack/commit/354c9035fe93d66b20314595ddc1bf1f53098539?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 2 commits behind head on main.
   
   > :exclamation:  There is a different number of reports uploaded between BASE (9dceae4) and HEAD (354c903). Click for more details.
   > 
   > <details><summary>HEAD has 1 upload less than BASE</summary>
   >
   >| Flag | BASE (9dceae4) | HEAD (354c903) |
   >|------|------|------|
   >|unittests|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@              Coverage Diff              @@
   ##               main   #10593       +/-   ##
   =============================================
   - Coverage     16.30%    3.99%   -12.31%     
   =============================================
     Files          5674      398     -5276     
     Lines        499213    32589   -466624     
     Branches      60367     5777    -54590     
   =============================================
   - Hits          81383     1302    -80081     
   + Misses       408759    31137   -377622     
   + Partials       9071      150     -8921     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10593/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10593/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.99% <ø> (ø)` | |
   | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10593/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10593?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] In Install.md->CloudStack UI Commands(npm) [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10593:
URL: https://github.com/apache/cloudstack/pull/10593#issuecomment-2747540022

   > LGTM. Should we remove this line though https://github.com/apache/cloudstack/pull/10593/files#diff-09b140a43ebfdd8dbec31ce72cafffd15164d2860fd390692a030bcb932b54a0R92?
   
   yes and probably edit the line above as well.
   
   ```
   Open the following URL on your browser to access the Management Server UI:
   ```
   
   should read something like
   ```
   To access the Management Server UI, follow the following procedure:
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] In Install.md->CloudStack UI Commands(npm) [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #10593:
URL: https://github.com/apache/cloudstack/pull/10593


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org