You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/01/12 08:32:47 UTC

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #900: ble_gatt: Add subscribing helper functions

apache-mynewt-bot removed a comment on pull request #900:
URL: https://github.com/apache/mynewt-nimble/pull/900#issuecomment-758489868


   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### nimble/host/include/host/ble_gatt.h
   <details>
   
   ```diff
   @@ -528,7 +528,7 @@
     * @return                      0 on success; nonzero on failure.
     */
    int ble_gattc_subscribe_notifications(uint16_t conn_handle, uint16_t cccd_handle,
   -                                  ble_gatt_attr_fn *cb, void *cb_arg);
   +                                      ble_gatt_attr_fn *cb, void *cb_arg);
    
    /**
     * Subscribes to indication for characteristic of given CCCD.
   @@ -540,7 +540,7 @@
     * @return                      0 on success; nonzero on failure.
     */
    int ble_gattc_subscribe_indications(uint16_t conn_handle, uint16_t cccd_handle,
   -                                ble_gatt_attr_fn *cb, void *cb_arg);
   +                                    ble_gatt_attr_fn *cb, void *cb_arg);
    
    int ble_gattc_init(void);
    
   ```
   
   </details>
   
   #### nimble/host/src/ble_gattc.c
   <details>
   
   ```diff
   @@ -4366,8 +4366,9 @@
        return ble_gattc_indicate_custom(conn_handle, chr_val_handle, NULL);
    }
    
   -int ble_gattc_subscribe_notifications(uint16_t conn_handle, uint16_t cccd_handle,
   -                                      ble_gatt_attr_fn *cb, void *cb_arg)
   +int
   +ble_gattc_subscribe_notifications(uint16_t conn_handle, uint16_t cccd_handle,
   +                                  ble_gatt_attr_fn *cb, void *cb_arg)
    {
        int rc;
        uint16_t value = 0x0001;
   @@ -4377,8 +4378,9 @@
        return rc;
    }
    
   -int ble_gattc_subscribe_indications(uint16_t conn_handle, uint16_t cccd_handle,
   -                                      ble_gatt_attr_fn *cb, void *cb_arg)
   +int
   +ble_gattc_subscribe_indications(uint16_t conn_handle, uint16_t cccd_handle,
   +                                ble_gatt_attr_fn *cb, void *cb_arg)
    {
        int rc;
        uint16_t value = 0x0002;
   @@ -4389,8 +4391,8 @@
    }
    
    /*****************************************************************************
   - * $rx                                                                       *
   - *****************************************************************************/
   +* $rx                                                                       *
   +*****************************************************************************/
    
    /**
     * Dispatches an incoming ATT error-response to the appropriate active GATT
   ```
   
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org