You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/22 12:50:03 UTC

[GitHub] [flink] zhuzhurk opened a new pull request #14463: Flink 20721 remove unknown input

zhuzhurk opened a new pull request #14463:
URL: https://github.com/apache/flink/pull/14463


   ## What is the purpose of the change
   
   With the latest pipelined region scheduling, Flink no longer launches a task before knowing the locations of all the partitions it consumes. As a result, unknown input channels and the process to update it is no longer needed. 
   This PR is based on #14462
   
   ## Verifying this change
   
   This change is already covered by existing tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14463: [FLINK-20721][runtime] Remove unknown input channel and the process which updates it

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14463:
URL: https://github.com/apache/flink/pull/14463#issuecomment-749535125


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29acdcc913351289ca9440c4aeaaf6038453af7b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11179",
       "triggerID" : "29acdcc913351289ca9440c4aeaaf6038453af7b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29acdcc913351289ca9440c4aeaaf6038453af7b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11179) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuzhurk closed pull request #14463: [FLINK-20721][runtime] Remove unknown input channel and the process which updates it

Posted by GitBox <gi...@apache.org>.
zhuzhurk closed pull request #14463:
URL: https://github.com/apache/flink/pull/14463


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14463: [FLINK-20721][runtime] Remove unknown input channel and the process which updates it

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14463:
URL: https://github.com/apache/flink/pull/14463#issuecomment-749535125


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29acdcc913351289ca9440c4aeaaf6038453af7b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11179",
       "triggerID" : "29acdcc913351289ca9440c4aeaaf6038453af7b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29acdcc913351289ca9440c4aeaaf6038453af7b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11179) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14463: [FLINK-20721][runtime] Remove unknown input channel and the process which updates it

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14463:
URL: https://github.com/apache/flink/pull/14463#issuecomment-749535125


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29acdcc913351289ca9440c4aeaaf6038453af7b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "29acdcc913351289ca9440c4aeaaf6038453af7b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29acdcc913351289ca9440c4aeaaf6038453af7b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuzhurk commented on pull request #14463: [FLINK-20721][runtime] Remove unknown input channel and the process which updates it

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on pull request #14463:
URL: https://github.com/apache/flink/pull/14463#issuecomment-750139675


   Closing this ticket because UnknownInputChannel are still needed at the moment if BLOCKING edges exist in a pipelined region.
   
   e.g.
   A – pipelined --> B, A – pipelined --> C, B – pipelined --> D, C – blocking --> D.
   
   In this case, even though D knows the location of C when deployed, the corresponding input channel will be unknown because C has not finished producing the BLOCKING result partition. This is needed because reading from an uncompleted BLOCKING result partition is not supported yet.
   
   Besides that, UnknownInputChannel is possibly needed for future individual failover.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14463: Flink 20721 remove unknown input

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14463:
URL: https://github.com/apache/flink/pull/14463#issuecomment-749525523


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 29acdcc913351289ca9440c4aeaaf6038453af7b (Tue Dec 22 12:52:44 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **Invalid pull request title: No valid Jira ID provided**
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org