You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/29 14:19:54 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #4770: Update sqlparser to `29.0.0`
alamb opened a new pull request, #4770:
URL: https://github.com/apache/arrow-datafusion/pull/4770
# Which issue does this PR close?
N/a
# Rationale for this change
Keep up with dependencies
# What changes are included in this PR?
1. Update to sqlparser 29.0.0
2. Update code for changes in APIs
# Are these changes tested?
covered by existing tests
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4770: Update sqlparser to `29.0.0`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4770:
URL: https://github.com/apache/arrow-datafusion/pull/4770#issuecomment-1368205965
Thank you @Jefffrey ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jefffrey commented on pull request #4770: Update sqlparser to `29.0.0`
Posted by GitBox <gi...@apache.org>.
Jefffrey commented on PR #4770:
URL: https://github.com/apache/arrow-datafusion/pull/4770#issuecomment-1368212110
I raised an issue for that q41 specifically https://github.com/apache/arrow-datafusion/issues/4728
But can close if deemed duplicate of https://github.com/apache/arrow-datafusion/issues/4065
@alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4770: Update sqlparser to `29.0.0`
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4770:
URL: https://github.com/apache/arrow-datafusion/pull/4770#issuecomment-1368434757
Benchmark runs are scheduled for baseline = acb8846f5e7ab80eac4c85f6ccb4544fc3e089d5 and contender = 9a8190a46e574459e95f456a18a33d2f1f458533. 9a8190a46e574459e95f456a18a33d2f1f458533 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6966f1e63c1348feba262991640a0419...af746e5c5e3f4c539f0e0d4f06180d88/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a1a01ca312384c22be25f8a739c1020c...1c0a17415d6a4b62bfb2ee86c3148840/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/38d1ba2ea3474021afe977c2d1245977...219913de080a4cc0b318b254edeca3ca/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3b5871c495e043f1b6a3367833262d91...0700d427d40f414992b3dfbbc64bda43/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4770: Update sqlparser to `29.0.0`
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4770:
URL: https://github.com/apache/arrow-datafusion/pull/4770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4770: Update sqlparser to `29.0.0`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4770:
URL: https://github.com/apache/arrow-datafusion/pull/4770#issuecomment-1368208534
🤔 https://github.com/apache/arrow-datafusion/actions/runs/3812004377/jobs/6484978586
```
thread 'tpcds_logical_q41' has overflowed its stack
error: test failed, to rerun pass `-p datafusion --test tpcds_planning`
Caused by:
process didn't exit successfully: `D:\a\arrow-datafusion\arrow-datafusion\target\debug\deps\tpcds_planning-89b1905225e9ab66.exe` (exit code: 0xc00000fd, STATUS_STACK_OVERFLOW)
Error: Process completed with exit code 127.
```
Looks like #4065 -- will check it out later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4770: Update sqlparser to `29.0.0`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4770:
URL: https://github.com/apache/arrow-datafusion/pull/4770#issuecomment-1368433190
Crazily enough https://github.com/apache/arrow-datafusion/pull/4770/commits/aa0c85a7e016cff81abcc01001539b24a9aeb776 was enough to fix the overflow for this PR. I am working on a more comprehensive fix in https://github.com/apache/arrow-datafusion/issues/4065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4770: Update sqlparser to `29.0.0`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4770:
URL: https://github.com/apache/arrow-datafusion/pull/4770#issuecomment-1367366653
FYI @Jefffrey and @tustvold and @waitingkuo who I think added things to sqlparser-rs in the latest release
@Jefffrey do you have time to update datafusion to parse cube/grouping sets (likely needed due to https://github.com/sqlparser-rs/sqlparser-rs/pull/771) ?
Here is the failure:
```shell
cargo test -p datafusion --test sql_integration
failures:
---- sql::aggregates::count_aggregated_cube stdout ----
Error: NotImplemented("Unsupported ast node in sqltorel: Cube([[Identifier(Ident { value: \"c1\", quote_style: None })], [Identifier(Ident { value: \"c2\", quote_style: None })]])")
failures:
sql::aggregates::count_aggregated_cube
test result: FAILED. 551 passed; 1 failed; 8 ignored; 0 measured; 0 filtered out; finished in 37.47s
error: test failed, to rerun pass `-p datafusion --test sql_integration`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jefffrey commented on pull request #4770: Update sqlparser to `29.0.0`
Posted by GitBox <gi...@apache.org>.
Jefffrey commented on PR #4770:
URL: https://github.com/apache/arrow-datafusion/pull/4770#issuecomment-1367582808
I've made PR into your branch: https://github.com/alamb/arrow-datafusion/pull/6
For the grouping sets changes
@alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4770: Update sqlparser to `29.0.0`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4770:
URL: https://github.com/apache/arrow-datafusion/pull/4770#issuecomment-1368225094
I have a fix for the stack overflow here: https://github.com/apache/arrow-datafusion/pull/4779
I have an idea how to work around it in this pr 🏃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org