You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2020/03/03 02:09:47 UTC
[kudu-CR] [cmake] Fix mini-hms Java build in certain cases
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15343
to review the following change.
Change subject: [cmake] Fix mini-hms Java build in certain cases
......................................................................
[cmake] Fix mini-hms Java build in certain cases
This change fixes the following error when trying to build Kudu for the
first time on a fresh install of Ubuntu 18.04:
$ ninja
[9/482] Building Java objects for hms-plugin.jar
FAILED: src/kudu/hms/CMakeFiles/hms-plugin.dir/java_compiled_hms-plugin
cd /home/mpercy/src/kudu/src/kudu/hms && /usr/lib/jvm/java-1.8.0-openjdk-amd64/bin/javac -classpath :/home/mpercy/src/kudu/src/kudu/hms:/home/mpercy/src/kudu/build/dynclang/bin -d /home/mpercy/src/kudu/build/dynclang/src/kudu/hms/CMakeFiles/hms-plugin.dir @/home/mpercy/src/kudu/build/dynclang/src/kudu/hms/CMakeFiles/hms-plugin.dir/java_sources && /home/mpercy/src/kudu/thirdparty/installed/common/bin/cmake -E touch /home/mpercy/src/kudu/build/dynclang/src/kudu/hms/CMakeFiles
/hms-plugin.dir/java_compiled_hms-plugin
/home/mpercy/src/kudu/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java:23: error: package com.google.common.annotations does not exist
import com.google.common.annotations.VisibleForTesting;
^
/home/mpercy/src/kudu/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java:24: error: package org.apache.hadoop.conf does not exist
import org.apache.hadoop.conf.Configuration;
^
/home/mpercy/src/kudu/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java:25: error: package org.apache.hadoop.hive.metastore does not exist
import org.apache.hadoop.hive.metastore.MetaStoreEventListener;
^
Looking at the verbose ninja output, I could see that the globbed jars
were not being included in the classpath for the javac command.
Change-Id: I736d8da837030c641d6a06c0cc812fffc0854667
---
M src/kudu/hms/CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/15343/1
--
To view, visit http://gerrit.cloudera.org:8080/15343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I736d8da837030c641d6a06c0cc812fffc0854667
Gerrit-Change-Number: 15343
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] [cmake] Fix mini-hms Java build in certain cases
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15343 )
Change subject: [cmake] Fix mini-hms Java build in certain cases
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I736d8da837030c641d6a06c0cc812fffc0854667
Gerrit-Change-Number: 15343
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 Mar 2020 02:33:17 +0000
Gerrit-HasComments: No
[kudu-CR] [cmake] Fix mini-hms Java build in certain cases
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15343 )
Change subject: [cmake] Fix mini-hms Java build in certain cases
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins due to flaky SlowTabletBootstrapTest.TestFallBehindSlowBootstrap
--
To view, visit http://gerrit.cloudera.org:8080/15343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I736d8da837030c641d6a06c0cc812fffc0854667
Gerrit-Change-Number: 15343
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 03 Mar 2020 03:02:21 +0000
Gerrit-HasComments: No
[kudu-CR] [cmake] Fix mini-hms Java build in certain cases
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has removed a vote on this change.
Change subject: [cmake] Fix mini-hms Java build in certain cases
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I736d8da837030c641d6a06c0cc812fffc0854667
Gerrit-Change-Number: 15343
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [cmake] Fix mini-hms Java build in certain cases
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15343 )
Change subject: [cmake] Fix mini-hms Java build in certain cases
......................................................................
[cmake] Fix mini-hms Java build in certain cases
This change fixes the following error when trying to build Kudu for the
first time on a fresh install of Ubuntu 18.04:
$ ninja
[9/482] Building Java objects for hms-plugin.jar
FAILED: src/kudu/hms/CMakeFiles/hms-plugin.dir/java_compiled_hms-plugin
cd /home/mpercy/src/kudu/src/kudu/hms && /usr/lib/jvm/java-1.8.0-openjdk-amd64/bin/javac -classpath :/home/mpercy/src/kudu/src/kudu/hms:/home/mpercy/src/kudu/build/dynclang/bin -d /home/mpercy/src/kudu/build/dynclang/src/kudu/hms/CMakeFiles/hms-plugin.dir @/home/mpercy/src/kudu/build/dynclang/src/kudu/hms/CMakeFiles/hms-plugin.dir/java_sources && /home/mpercy/src/kudu/thirdparty/installed/common/bin/cmake -E touch /home/mpercy/src/kudu/build/dynclang/src/kudu/hms/CMakeFiles
/hms-plugin.dir/java_compiled_hms-plugin
/home/mpercy/src/kudu/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java:23: error: package com.google.common.annotations does not exist
import com.google.common.annotations.VisibleForTesting;
^
/home/mpercy/src/kudu/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java:24: error: package org.apache.hadoop.conf does not exist
import org.apache.hadoop.conf.Configuration;
^
/home/mpercy/src/kudu/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java:25: error: package org.apache.hadoop.hive.metastore does not exist
import org.apache.hadoop.hive.metastore.MetaStoreEventListener;
^
Looking at the verbose ninja output, I could see that the globbed jars
were not being included in the classpath for the javac command.
Change-Id: I736d8da837030c641d6a06c0cc812fffc0854667
Reviewed-on: http://gerrit.cloudera.org:8080/15343
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Mike Percy <mp...@apache.org>
---
M src/kudu/hms/CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Grant Henke: Looks good to me, approved
Mike Percy: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I736d8da837030c641d6a06c0cc812fffc0854667
Gerrit-Change-Number: 15343
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>