You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "valentinDruzhinin (via GitHub)" <gi...@apache.org> on 2025/03/07 02:52:22 UTC
[PR] Fixes issue: https://github.com/apache/airflow/issues/40212 [airflow]
valentinDruzhinin opened a new pull request, #47479:
URL: https://github.com/apache/airflow/pull/47479
This is fixes issue: [40212](https://github.com/apache/airflow/issues/40212)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extend documentation for bigquery view for BigQueryUpdateTableOperator [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #47479:
URL: https://github.com/apache/airflow/pull/47479#issuecomment-2727897325
cc @VladaZakharova can you review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extend documentation for bigquery view for BigQueryUpdateTableOperator [airflow]
Posted by "VladaZakharova (via GitHub)" <gi...@apache.org>.
VladaZakharova commented on PR #47479:
URL: https://github.com/apache/airflow/pull/47479#issuecomment-2812063496
@eladkal Unfortunately no, i was waiting for response from @MokhFn, but if he is not about to test it, then i will check it next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extend documentation for bigquery view for BigQueryUpdateTableOperator [airflow]
Posted by "valentinDruzhinin (via GitHub)" <gi...@apache.org>.
valentinDruzhinin commented on PR #47479:
URL: https://github.com/apache/airflow/pull/47479#issuecomment-2709344936
> @valentinDruzhinin could you update the title to be more explicit on what the change you're making? Something along the lines of adding update view to big query docs or something similar? You can look at other commits for inspiration.
Thank you, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes issue: https://github.com/apache/airflow/issues/40212 [airflow]
Posted by "MaksYermak (via GitHub)" <gi...@apache.org>.
MaksYermak commented on PR #47479:
URL: https://github.com/apache/airflow/pull/47479#issuecomment-2706207777
Hello @valentinDruzhinin !
Could you please provide a screenshot that this [example_bigquery_tables.py](https://github.com/apache/airflow/pull/47479/files#diff-b4438e6b9a5d880dd10348db43cf9756c4b8a26ac8a0f7bb4d46cc4342663327) system test passed successfully on your Airflow environment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extend documentation for bigquery view for BigQueryUpdateTableOperator [airflow]
Posted by "VladaZakharova (via GitHub)" <gi...@apache.org>.
VladaZakharova commented on PR #47479:
URL: https://github.com/apache/airflow/pull/47479#issuecomment-2728718331
I am afraid I have concernes about this change and I would like to see the system test green :)
If @MokhFn can test it then great, if no, I think my team can help with that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extend documentation for bigquery view for BigQueryUpdateTableOperator [airflow]
Posted by "valentinDruzhinin (via GitHub)" <gi...@apache.org>.
valentinDruzhinin commented on code in PR #47479:
URL: https://github.com/apache/airflow/pull/47479#discussion_r2082766081
##########
providers/google/tests/system/google/cloud/bigquery/example_bigquery_tables.py:
##########
@@ -234,6 +260,8 @@
delete_view,
]
>> update_table
+ >> update_view
Review Comment:
@Crowiant thank you :) this is fixed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extend documentation for bigquery view for BigQueryUpdateTableOperator [airflow]
Posted by "Crowiant (via GitHub)" <gi...@apache.org>.
Crowiant commented on code in PR #47479:
URL: https://github.com/apache/airflow/pull/47479#discussion_r2049174025
##########
providers/google/tests/system/google/cloud/bigquery/example_bigquery_tables.py:
##########
@@ -234,6 +260,8 @@
delete_view,
]
>> update_table
+ >> update_view
Review Comment:
Hello @valentinDruzhinin update_view should be before delete view operator. I ran the example and now it fails with 404 error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extend documentation for bigquery view for BigQueryUpdateTableOperator [airflow]
Posted by "valentinDruzhinin (via GitHub)" <gi...@apache.org>.
valentinDruzhinin commented on PR #47479:
URL: https://github.com/apache/airflow/pull/47479#issuecomment-2709346872
> Hello @valentinDruzhinin ! Could you please provide a screenshot that this [example_bigquery_tables.py](https://github.com/apache/airflow/pull/47479/files#diff-b4438e6b9a5d880dd10348db43cf9756c4b8a26ac8a0f7bb4d46cc4342663327) system test passed successfully on your Airflow environment?
I'm not sure I'm able to test it locally. Because I need GCP access for it. @MokhFn maybe you can help me with that on your side?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extend documentation for bigquery view for BigQueryUpdateTableOperator [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #47479:
URL: https://github.com/apache/airflow/pull/47479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extend documentation for bigquery view for BigQueryUpdateTableOperator [airflow]
Posted by "Crowiant (via GitHub)" <gi...@apache.org>.
Crowiant commented on code in PR #47479:
URL: https://github.com/apache/airflow/pull/47479#discussion_r2049174025
##########
providers/google/tests/system/google/cloud/bigquery/example_bigquery_tables.py:
##########
@@ -234,6 +260,8 @@
delete_view,
]
>> update_table
+ >> update_view
Review Comment:
Hello @valentinDruzhinin update_view should be before delete view operator. I ran the example and it failed with 404 error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extend documentation for bigquery view for BigQueryUpdateTableOperator [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #47479:
URL: https://github.com/apache/airflow/pull/47479#issuecomment-2811596264
@VladaZakharova did you get a chance to check it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes issue: https://github.com/apache/airflow/issues/40212 [airflow]
Posted by "aritra24 (via GitHub)" <gi...@apache.org>.
aritra24 commented on PR #47479:
URL: https://github.com/apache/airflow/pull/47479#issuecomment-2705532766
@valentinDruzhinin could you update the title to be more explicit on what the change you're making? Something along the lines of adding update view to big query docs or something similar? You can look at other commits for inspiration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org