You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avalon.apache.org by Leo Sutic <le...@inspireinfrastructure.com> on 2003/04/30 15:43:20 UTC
[VOTE] RE: DO NOT REPLY [Bug 19448] - NPE possible from DefaultComponentFactory
Bug is here:
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19448
Arguments are as follows:
Testcase and PATCH to follow
------- Additional Comments From tagunov@motor.ru 2003-04-29 23:19
-------
Created an attachment (id=6092)
fix possible NPE from DefaultComponentFactory
------- Additional Comments From tagunov@motor.ru 2003-04-29 23:20
-------
Created an attachment (id=6093)
Test case not to let this bug slip back ever again :-)
------- Additional Comments From leo.sutic@inspireinfrastructure.com
2003-04-30 12:32 -------
I don't like this - if there is no LogKitManager and you have components
requiring one, all you do is postpone the big bang until the component
tries to
use the non-existant LogKitManager. Might as well blow quickly.
------- Additional Comments From tagunov@motor.ru 2003-04-30 13:27
-------
But then the DefaultComponentSelector from ECM should be fixed - it
implements LoggerManageable
is it blows up if there isn't one!
But this does not allow for a simple setup with just a single
logger - and ComponentSelector in ECM is necessary for example for such
a simple thing as setting up
factories for SourceResolver
------- Additional Comments From leo.sutic@inspireinfrastructure.com
2003-04-30 13:38 -------
Well, the DefaultComponentSelector is fully entitled to explode in any
way it
sees fit if the container can't honor the contract between itself and
the
Selector.
Yes, you need a LogKitManager to set up a sourceresolver for a simple
example,
but that's the way it is. I prefer that to weakening the contract.
Keeping this bug open, but not applying the patch & calling for a vote
on the
list (i.e. let's close this bug, one way or the other).
CALL FOR VOTE:
Should the patch be applied? +1 or -1.
-1 from me for the reasons above. Willing to change given some argument
that addresses the weakening of the contract (I think it would be better
to make it easy to supply a LogKitManager than to blur the contracts).
/LS
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org
Re: [VOTE] RE: DO NOT REPLY [Bug 19448] - NPE possible from
DefaultComponentFactory
Posted by Leo Simons <le...@apache.org>.
Leo Sutic wrote:
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19448
>
> CALL FOR VOTE:
>
> Should the patch be applied? +1 or -1.
>
> -1 from me for the reasons above.
-1 from me on the same grounds.
- Leo
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org