[I] [Bug] Missing Configuration in bookkeeper.conf [pulsar]

["sandeep-mst (via GitHub)" <gi...@apache.org>]

sandeep-mst opened a new issue, #23818:
URL: https://github.com/apache/pulsar/issues/23818

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
   
   
   ### Read release policy
   
   - [X] I understand that unsupported versions don't get bug fixes. I will attempt to reproduce the issue on a supported version of Pulsar client and Pulsar broker.
   
   
   ### Version
   
   OS - macOS 14.5 (23F79)
   Java Version - 17
   Pulsar Client Version - 4.0.1, 3.0.x
   Pulsar Broker Version - 4.0.1, 3.0.x
   
   ### Minimal reproduce step
   
   - Set env values for `minorCompactionMaxTimeMillis`  and `majorCompactionMaxTimeMillis` and run `apply-config-from-env.py`.
   
   Alternatively, it can be reproduced using pulsar-helm-chart and populating the values in `.Values.bookkeeper.configData`. Internally it uses the `apply-config-from-env.py` script to update values in `bookkeeper.conf`.
   
   ### What did you expect to see?
   
   `minorCompactionMaxTimeMillis`  and `majorCompactionMaxTimeMillis` parameters being configured in bookkeeper.conf.
   
   ### What did you see instead?
   
   `minorCompactionMaxTimeMillis`  and `majorCompactionMaxTimeMillis` parameters are missing from bookkeeper.conf even after running the script.
   
   ### Anything else?
   
   We need to add these parameters to `bookkeeper.conf` to allow the script to update them.
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Bug] Missing Configuration in bookkeeper.conf [pulsar]

["merlimat (via GitHub)" <gi...@apache.org>]

merlimat commented on issue #23818:
URL: https://github.com/apache/pulsar/issues/23818#issuecomment-6380960639

   Confirmed on current master: conf/bookkeeper.conf (around line 556 for minor and 579 for major compaction on master) still doesn't list `minorCompactionMaxTimeMillis` or `majorCompactionMaxTimeMillis`, so `apply-config-from-env.py` only replaces keys that are already in the file and ignores these when they're set without a prefix. Until they're added, set them as `PULSAR_PREFIX_minorCompactionMaxTimeMillis` / `PULSAR_PREFIX_majorCompactionMaxTimeMillis`, which the script appends to the file. The likely fix is to add both keys, commented with their defaults, next to the other compaction settings in conf/bookkeeper.conf (ideally as part of syncing the file with BookKeeper's bk_server.conf, as suggested on #23819).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org