You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by David Nalley <da...@gnsa.us> on 2012/07/30 14:55:20 UTC

Re: git commit: rrq 5839: This table should not have a contraint on device and physical network id. This is dealt with in the code and by using the removed field.

This changes needs to be propagated to the upgrade scripts as well,
otherwise the item you removed will persist in upgrades.

--David

On Mon, Jul 30, 2012 at 2:47 AM,  <hu...@apache.org> wrote:
> Updated Branches:
>   refs/heads/master 3313cc4a8 -> 894407caa
>
>
> rrq 5839: This table should not have a contraint on device and physical network id. This is dealt with in the code and by using the removed field.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
> Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/894407ca
> Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/894407ca
> Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/894407ca
>
> Branch: refs/heads/master
> Commit: 894407caa97ecd5b4f034de6b3b0e4deadd253e4
> Parents: 3313cc4
> Author: Hugo Trippaers <ht...@schubergphilis.com>
> Authored: Mon Jul 30 08:46:56 2012 +0200
> Committer: Hugo Trippaers <ht...@schubergphilis.com>
> Committed: Mon Jul 30 08:46:56 2012 +0200
>
> ----------------------------------------------------------------------
>  setup/db/create-schema.sql |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/894407ca/setup/db/create-schema.sql
> ----------------------------------------------------------------------
> diff --git a/setup/db/create-schema.sql b/setup/db/create-schema.sql
> index ae5f581..dc9e7b0 100755
> --- a/setup/db/create-schema.sql
> +++ b/setup/db/create-schema.sql
> @@ -2000,7 +2000,6 @@ CREATE TABLE `cloud`.`physical_network_service_providers` (
>    PRIMARY KEY (`id`),
>    CONSTRAINT `fk_pnetwork_service_providers__physical_network_id` FOREIGN KEY (`physical_network_id`) REFERENCES `physical_network`(`id`) ON DELETE CASCADE,
>    CONSTRAINT `uc_service_providers__uuid` UNIQUE (`uuid`),
> -  UNIQUE KEY(`physical_network_id`, `provider_name`)
>  ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
>
>  CREATE TABLE `cloud`.`external_load_balancer_devices` (
>

RE: git commit: rrq 5839: This table should not have a contraint on device and physical network id. This is dealt with in the code and by using the removed field.

Posted by Hugo Trippaers <HT...@schubergphilis.com>.
Hey David,

The upgrade script is updated, was a bit more work than I expected as the unique constraint was unnamed.

Cheers,

Hugo

-----Original Message-----
From: David Nalley [mailto:david@gnsa.us] 
Sent: Monday, July 30, 2012 2:55 PM
To: cloudstack-dev@incubator.apache.org
Subject: Re: git commit: rrq 5839: This table should not have a contraint on device and physical network id. This is dealt with in the code and by using the removed field.

This changes needs to be propagated to the upgrade scripts as well, otherwise the item you removed will persist in upgrades.

--David

On Mon, Jul 30, 2012 at 2:47 AM,  <hu...@apache.org> wrote:
> Updated Branches:
>   refs/heads/master 3313cc4a8 -> 894407caa
>
>
> rrq 5839: This table should not have a contraint on device and physical network id. This is dealt with in the code and by using the removed field.
>
>
> Project: 
> http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
> Commit: 
> http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/894
> 407ca
> Tree: 
> http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/89440
> 7ca
> Diff: 
> http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/89440
> 7ca
>
> Branch: refs/heads/master
> Commit: 894407caa97ecd5b4f034de6b3b0e4deadd253e4
> Parents: 3313cc4
> Author: Hugo Trippaers <ht...@schubergphilis.com>
> Authored: Mon Jul 30 08:46:56 2012 +0200
> Committer: Hugo Trippaers <ht...@schubergphilis.com>
> Committed: Mon Jul 30 08:46:56 2012 +0200
>
> ----------------------------------------------------------------------
>  setup/db/create-schema.sql |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/89440
> 7ca/setup/db/create-schema.sql
> ----------------------------------------------------------------------
> diff --git a/setup/db/create-schema.sql b/setup/db/create-schema.sql 
> index ae5f581..dc9e7b0 100755
> --- a/setup/db/create-schema.sql
> +++ b/setup/db/create-schema.sql
> @@ -2000,7 +2000,6 @@ CREATE TABLE `cloud`.`physical_network_service_providers` (
>    PRIMARY KEY (`id`),
>    CONSTRAINT `fk_pnetwork_service_providers__physical_network_id` FOREIGN KEY (`physical_network_id`) REFERENCES `physical_network`(`id`) ON DELETE CASCADE,
>    CONSTRAINT `uc_service_providers__uuid` UNIQUE (`uuid`),
> -  UNIQUE KEY(`physical_network_id`, `provider_name`)
>  ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
>
>  CREATE TABLE `cloud`.`external_load_balancer_devices` (
>