You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/12/23 06:53:09 UTC

[GitHub] [ozone] symious opened a new pull request, #4123: HDDS-7703. Add num of datanodes metrics in ScmBlockDeletingServiceMetrics

symious opened a new pull request, #4123:
URL: https://github.com/apache/ozone/pull/4123

   ## What changes were proposed in this pull request?
   
   SCM sends delete block commands to different datanodes. 
   
   There is a chance that one datanode has some issue handling the requests, and SCM will be sending all requests to the same datanode. 
   
   This metrics should be helpful to notice this issue.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-7703
   
   ## How was this patch tested?
   
   unit test.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] kerneltime commented on pull request #4123: HDDS-7703. Add num of datanodes metrics in ScmBlockDeletingServiceMetrics

Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #4123:
URL: https://github.com/apache/ozone/pull/4123#issuecomment-1375969160

   @swamirishi can you please take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-7703. Add num of datanodes metrics in ScmBlockDeletingServiceMetrics [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4123:
URL: https://github.com/apache/ozone/pull/4123#issuecomment-1763445078

   @symious @ChenSammi @sumitagrawl what should we do with this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] ChenSammi commented on pull request #4123: HDDS-7703. Add num of datanodes metrics in ScmBlockDeletingServiceMetrics

Posted by GitBox <gi...@apache.org>.
ChenSammi commented on PR #4123:
URL: https://github.com/apache/ozone/pull/4123#issuecomment-1379871218

   Hi @symious , this numDatanodesSentCommands will be overwritten every time SCM sends out a new batch of delete blocks.  Could you explain a little further how this transient value will be helpful for issue diagnose? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on pull request #4123: HDDS-7703. Add num of datanodes metrics in ScmBlockDeletingServiceMetrics

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4123:
URL: https://github.com/apache/ozone/pull/4123#issuecomment-1537347877

   @ChenSammi please take another look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-7703. Add num of datanodes metrics in ScmBlockDeletingServiceMetrics [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4123:
URL: https://github.com/apache/ozone/pull/4123#issuecomment-1913251079

   Please feel free to reopen if you would like to continue working on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] symious commented on pull request #4123: HDDS-7703. Add num of datanodes metrics in ScmBlockDeletingServiceMetrics

Posted by GitBox <gi...@apache.org>.
symious commented on PR #4123:
URL: https://github.com/apache/ozone/pull/4123#issuecomment-1381201593

   Sure. 
   Normally the delete requests will be send evenly to all datanodes, but sometimes we met the slow deleting issue caused by some slow datanodes. At this scenario, all the requests will be send only to one or a small amount of datanodes. 
   With this metrics, SRE could identify this kind of issue and handle the slow datanode quickly to help improve the deleting speed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-7703. Add num of datanodes metrics in ScmBlockDeletingServiceMetrics [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai closed pull request #4123: HDDS-7703. Add num of datanodes metrics in ScmBlockDeletingServiceMetrics
URL: https://github.com/apache/ozone/pull/4123


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] DaveTeng0 commented on pull request #4123: HDDS-7703. Add num of datanodes metrics in ScmBlockDeletingServiceMetrics

Posted by "DaveTeng0 (via GitHub)" <gi...@apache.org>.
DaveTeng0 commented on PR #4123:
URL: https://github.com/apache/ozone/pull/4123#issuecomment-1418655003

   Hey @symious ~ there is some small conflict, otherwise looks good to me!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org