You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/12/05 04:30:18 UTC
[kudu-CR] [style] re-order x.h and x-inl.h to please IWYU
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14844
Change subject: [style] re-order x.h and x-inl.h to please IWYU
......................................................................
[style] re-order x.h and x-inl.h to please IWYU
IWYU explicitly prefer x.h to precede x-inl.h in the ordering
of include files. This patch updated few files to adhere to
IWYU's preference, unifying the order of such include file pairs
across the codebase.
This patch doesn't contain any functional modifications.
Change-Id: I697416766610d169f1e13450310fd218c197b439
---
M src/kudu/cfile/block_pointer.h
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/index_block.cc
M src/kudu/cfile/plain_block.h
M src/kudu/tablet/rowset_tree.cc
5 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/14844/1
--
To view, visit http://gerrit.cloudera.org:8080/14844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I697416766610d169f1e13450310fd218c197b439
Gerrit-Change-Number: 14844
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [style] re-order x.h and x-inl.h to please IWYU
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14844 )
Change subject: [style] re-order x.h and x-inl.h to please IWYU
......................................................................
[style] re-order x.h and x-inl.h to please IWYU
IWYU explicitly prefer x.h to precede x-inl.h in the ordering
of include files. This patch updated few files to adhere to
IWYU's preference, unifying the order of such include file pairs
across the codebase.
This patch doesn't contain any functional modifications.
Change-Id: I697416766610d169f1e13450310fd218c197b439
Reviewed-on: http://gerrit.cloudera.org:8080/14844
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/cfile/block_pointer.h
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/index_block.cc
M src/kudu/cfile/plain_block.h
M src/kudu/tablet/rowset_tree.cc
5 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I697416766610d169f1e13450310fd218c197b439
Gerrit-Change-Number: 14844
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [style] re-order x.h and x-inl.h to please IWYU
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14844 )
Change subject: [style] re-order x.h and x-inl.h to please IWYU
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I697416766610d169f1e13450310fd218c197b439
Gerrit-Change-Number: 14844
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 05 Dec 2019 04:33:51 +0000
Gerrit-HasComments: No